lib: remove startsWith/endsWith primordials for char checks

PR-URL: #55407
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Author: gurgunday

lib/_http_agent.js

@@ -341,7 +341,7 @@ function calculateServerName(options, req) {
 // abc:123 => abc
 // [::1] => ::1
 // [::1]:123 => ::1
-if(hostHeader.startsWith('[')){
+if(hostHeader[0]==='['){
 constindex=hostHeader.indexOf(']');
 if(index===-1){
 // Leading '[', but no ']'. Need to do something...

lib/internal/main/watch_mode.js

@@ -46,7 +46,7 @@ for (let i = 0; i < process.execArgv.length; i++) {
 if(StringPrototypeStartsWith(arg,'--watch')){
 i++;
 constnextArg=process.execArgv[i];
-if(nextArg&&StringPrototypeStartsWith(nextArg,'-')){
+if(nextArg&&nextArg[0]==='-'){
 ArrayPrototypePush(argsWithoutWatchOptions,nextArg);
 }
 continue;

lib/internal/modules/esm/fetch_module.js

@@ -3,9 +3,7 @@ const {
  ObjectPrototypeHasOwnProperty,
  PromisePrototypeThen,
  SafeMap,
- StringPrototypeEndsWith,
  StringPrototypeSlice,
- StringPrototypeStartsWith,
 }=primordials;
 const{
 Buffer: {concat: BufferConcat},
@@ -248,8 +246,9 @@ allowList.addRange('127.0.0.1', '127.255.255.255');
 asyncfunctionisLocalAddress(hostname){
 try{
 if(
-StringPrototypeStartsWith(hostname,'[')&&
-StringPrototypeEndsWith(hostname,']')
+hostname.length&&
+hostname[0]==='['&&
+hostname[hostname.length-1]===']'
 ){
 hostname=StringPrototypeSlice(hostname,1,-1);
 }

lib/internal/modules/esm/resolve.js

@@ -373,8 +373,9 @@ function resolvePackageTargetString(
 }
 
 if(!StringPrototypeStartsWith(target,'./')){
-if(internal&&!StringPrototypeStartsWith(target,'../')&&
-!StringPrototypeStartsWith(target,'/')){
+if(internal&&
+target[0]!=='/'&&
+!StringPrototypeStartsWith(target,'../')){
 // No need to convert target to string, since it's already presumed to be
 if(!URLCanParse(target)){
 constexportTarget=pattern ?

lib/internal/modules/helpers.js

@@ -202,7 +202,7 @@ function addBuiltinLibsToObject(object, dummyModuleName) {
 ArrayPrototypeForEach(builtinModules,(name)=>{
 // Neither add underscored modules, nor ones that contain slashes (e.g.,
 // 'fs/promises') or ones that are already defined.
-if(StringPrototypeStartsWith(name,'_')||
+if(name[0]==='_'||
 StringPrototypeIncludes(name,'/')||
 ObjectPrototypeHasOwnProperty(object,name)){
 return;

lib/internal/process/per_thread.js

@@ -25,7 +25,6 @@ const {
  StringPrototypeEndsWith,
  StringPrototypeReplace,
  StringPrototypeSlice,
- StringPrototypeStartsWith,
  Symbol,
  SymbolIterator,
 }=primordials;
@@ -296,7 +295,7 @@ function buildAllowedFlags() {
 }
 
 functionisAccepted(to){
-if(!StringPrototypeStartsWith(to,'-')||to==='--')returntrue;
+if(!to.length||to[0]!=='-'||to==='--')returntrue;
 constrecursiveExpansion=aliases.get(to);
 if(recursiveExpansion){
 if(recursiveExpansion[0]===to)

lib/internal/process/pre_execution.js

@@ -13,7 +13,6 @@ const {
  ObjectDefineProperty,
  ObjectFreeze,
  String,
- StringPrototypeStartsWith,
  globalThis,
 }=primordials;
 
@@ -206,8 +205,7 @@ function patchProcessObject(expandArgv1) {
 letmainEntry;
 // If requested, update process.argv[1] to replace whatever the user provided with the resolved absolute file path of
 // the entry point.
-if(expandArgv1&&process.argv[1]&&
-!StringPrototypeStartsWith(process.argv[1],'-')){
+if(expandArgv1&&process.argv[1]&&process.argv[1][0]!=='-'){
 // Expand process.argv[1] into a full path.
 constpath=require('path');
 try{

lib/internal/repl/utils.js

@@ -10,12 +10,10 @@ const {
  RegExpPrototypeExec,
  SafeSet,
  SafeStringIterator,
- StringPrototypeEndsWith,
  StringPrototypeIndexOf,
  StringPrototypeLastIndexOf,
  StringPrototypeReplaceAll,
  StringPrototypeSlice,
- StringPrototypeStartsWith,
  StringPrototypeToLowerCase,
  StringPrototypeTrim,
  Symbol,
@@ -298,8 +296,7 @@ function setupPreview(repl, contextSymbol, bufferSymbol, active) {
 functiongetInputPreview(input,callback){
 // For similar reasons as `defaultEval`, wrap expressions starting with a
 // curly brace with parenthesis.
-if(StringPrototypeStartsWith(input,'{')&&
-!StringPrototypeEndsWith(input,';')&&!wrapped){
+if(!wrapped&&input[0]==='{'&&input[input.length-1]!==';'){
 input=`(${input})`;
 wrapped=true;
 }

lib/internal/url.js

@@ -1416,7 +1416,7 @@ function urlToHttpOptions(url) {
 __proto__: null,
  ...url,// In case the url object was extended by the user.
 protocol: url.protocol,
-hostname: hostname&&StringPrototypeStartsWith(hostname,'[') ?
+hostname: hostname&&hostname[0]==='[' ?
 StringPrototypeSlice(hostname,1,-1) :
 hostname,
 hash: url.hash,

lib/internal/util/inspect.js

@@ -1190,7 +1190,7 @@ function getClassBase(value, constructor, tag) {
 
 functiongetFunctionBase(value,constructor,tag){
 conststringified=FunctionPrototypeToString(value);
-if(StringPrototypeStartsWith(stringified,'class')&&StringPrototypeEndsWith(stringified,'}')){
+if(StringPrototypeStartsWith(stringified,'class')&&stringified[stringified.length-1]==='}'){
 constslice=StringPrototypeSlice(stringified,5,-1);
 constbracketIndex=StringPrototypeIndexOf(slice,'{');
 if(bracketIndex!==-1&&
@@ -1573,7 +1573,8 @@ function handleMaxCallStackSize(ctx, err, constructorName, indentationLvl) {
 functionaddNumericSeparator(integerString){
 letresult='';
 leti=integerString.length;
-conststart=StringPrototypeStartsWith(integerString,'-') ? 1 : 0;
+assert(i!==0);
+conststart=integerString[0]==='-' ? 1 : 0;
 for(;i>=start+4;i-=3){
 result=`_${StringPrototypeSlice(integerString,i-3,i)}${result}`;
 }