http: refactor to avoid unsafe array iteration

PR-URL: #37124
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: aduh95

lib/_http_agent.js

@@ -200,8 +200,9 @@ function maybeEnableKeylog(eventName) {
 agent.emit('keylog',keylog,this);
 };
 // Existing sockets will start listening on keylog now.
-for(constsocketofObjectValues(this.sockets)){
-socket.on('keylog',this[kOnKeylog]);
+constsockets=ObjectValues(this.sockets);
+for(leti=0;i<sockets.length;i++){
+sockets[i].on('keylog',this[kOnKeylog]);
 }
 }
 }
@@ -424,7 +425,9 @@ Agent.prototype.removeSocket = function removeSocket(s, options) {
 if(!s.writable)
 ArrayPrototypePush(sets,this.freeSockets);
 
-for(constsocketsofsets){
+for(letsk=0;sk<sets.length;sk++){
+constsockets=sets[sk];
+
 if(sockets[name]){
 constindex=ArrayPrototypeIndexOf(sockets[name],s);
 if(index!==-1){
@@ -490,10 +493,14 @@ Agent.prototype.reuseSocket = function reuseSocket(socket, req) {
 };
 
 Agent.prototype.destroy=functiondestroy(){
-for(constsetof[this.freeSockets,this.sockets]){
-for(constkeyofObjectKeys(set)){
-for(constsetNameofset[key]){
-setName.destroy();
+constsets=[this.freeSockets,this.sockets];
+for(lets=0;s<sets.length;s++){
+constset=sets[s];
+constkeys=ObjectKeys(set);
+for(letv=0;v<keys.length;v++){
+constsetName=set[keys[v]];
+for(letn=0;n<setName.length;n++){
+setName[n].destroy();
 }
 }
 }

lib/_http_outgoing.js

@@ -23,6 +23,7 @@
 
 const{
  ArrayIsArray,
+ ArrayPrototypeForEach,
  ArrayPrototypeJoin,
  ArrayPrototypePush,
  ArrayPrototypeUnshift,
@@ -390,9 +391,9 @@ function _storeHeader(firstLine, headers) {
 }
 }elseif(ArrayIsArray(headers)){
 if(headers.length&&ArrayIsArray(headers[0])){
-for(constentryofheaders){
-processHeader(this,state,entry[0],entry[1],true);
-}
+ArrayPrototypeForEach(headers,(entry)=>
+processHeader(this,state,entry[0],entry[1],true)
+);
 }else{
 if(headers.length%2!==0){
 thrownewERR_INVALID_ARG_VALUE('headers',headers);

lib/_http_server.js

@@ -23,6 +23,7 @@
 
 const{
  ArrayIsArray,
+ ArrayPrototypeForEach,
  ArrayPrototypePush,
  ArrayPrototypeShift,
  Error,
@@ -417,9 +418,8 @@ Server.prototype[EE.captureRejectionSymbol] = function(err, event, ...args) {
 const[,res]=args;
 if(!res.headersSent&&!res.writableEnded){
 // Don't leak headers.
-for(constnameofres.getHeaderNames()){
-res.removeHeader(name);
-}
+ArrayPrototypeForEach(res.getHeaderNames(),
+(name)=>res.removeHeader(name));
 res.statusCode=500;
 res.end(STATUS_CODES[500]);
 }else{