http2: do not override the allowHalfOpen option

lpinca · targos · commit 74046cee7205 · 2019-05-13T18:12:42.000+02:00
The constructors of `tls.Server` and `Http2Server` call the super constructors without options so the `allowHalfOpen` option is never used regardless of its value. PR-URL: #27623 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -2643,7 +2643,6 @@ function connectionListener(socket) {
 function initializeOptions(options) {
 assertIsObject(options, 'options');
 options = { ...options };
- options.allowHalfOpen = true;
 assertIsObject(options.settings, 'options.settings');
 options.settings = { ...options.settings };
 

-Original file line number
+Diff line change
 functioninitializeOptions(options){
 assertIsObject(options,'options');
 options={ ...options};
 -options.allowHalfOpen=true;
 assertIsObject(options.settings,'options.settings');
 options.settings={ ...options.settings};