test: make the rest of tests path-independent

Permit spaces in paths to a Node.js executable and test scripts.
PR-URL: #12972Fixes: #12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: vsemozhetbyt

test/common/index.js

@@ -214,8 +214,8 @@ exports.childShouldThrowAndAbort = function() {
 // continuous testing and developers' machines
 testCmd+='ulimit -c 0 && ';
 }
-testCmd+=`${process.argv[0]} --abort-on-uncaught-exception `;
-testCmd+=`${process.argv[1]} child`;
+testCmd+=`"${process.argv[0]}" --abort-on-uncaught-exception `;
+testCmd+=`"${process.argv[1]}" child`;
 constchild=child_process.exec(testCmd);
 child.on('exit',functiononExit(exitCode,signal){
 consterrMsg='Test should have aborted '+

test/known_issues/test-stdout-buffer-flush-on-exit.js

@@ -18,7 +18,8 @@ if (process.argv[2] === 'child') {
 [22,21,20,19,18,17,16,16,17,18,19,20,21,22].forEach((exponent)=>{
 constbigNum=Math.pow(2,exponent);
 constlongLine=lineSeed.repeat(bigNum);
-constcmd=`${process.execPath}${__filename} child ${exponent}${bigNum}`;
+constcmd=
+`"${process.execPath}" "${__filename}" child ${exponent}${bigNum}`;
 conststdout=execSync(cmd).toString().trim();
 
 assert.strictEqual(stdout,longLine,`failed with exponent ${exponent}`);

test/parallel/test-child-process-bad-stdio.js

@@ -27,7 +27,7 @@ ChildProcess.prototype.spawn = function() {
 };
 
 functioncreateChild(options,callback){
-constcmd=`${process.execPath}${__filename} child`;
+constcmd=`"${process.execPath}" "${__filename}" child`;
 
 returncp.exec(cmd,options,common.mustCall(callback));
 }

test/parallel/test-child-process-exec-encoding.js

@@ -13,7 +13,7 @@ if (process.argv[2] === 'child') {
 console.error(stderrData);
 }else{
 functionrun(options,callback){
-constcmd=`${process.execPath}${__filename} child`;
+constcmd=`"${process.execPath}" "${__filename}" child`;
 
 cp.exec(cmd,options,common.mustCall((err,stdout,stderr)=>{
 assert.ifError(err);

test/parallel/test-child-process-exec-timeout.js

@@ -12,7 +12,7 @@ if (process.argv[2] === 'child') {
 return;
 }
 
-constcmd=`${process.execPath}${__filename} child`;
+constcmd=`"${process.execPath}" "${__filename}" child`;
 
 // Test the case where a timeout is set, and it expires.
 cp.exec(cmd,{timeout: 1},common.mustCall((err,stdout,stderr)=>{

test/parallel/test-cli-eval.js

@@ -199,7 +199,7 @@ child.exec(`${nodejs} --use-strict -p process.execArgv`,
 // Ensure that arguments are successfully passed to a script.
 // The first argument after '--' should be interpreted as a script
 // filename.
-constfilecmd=`${nodejs} -- ${__filename}${args}`;
+constfilecmd=`${nodejs} -- "${__filename}"${args}`;
 child.exec(filecmd,common.mustCall(function(err,stdout,stderr){
 assert.strictEqual(stdout,`${args}\n`);
 assert.strictEqual(stderr,'');

test/parallel/test-domain-throw-error-then-throw-from-uncaught-exception-handler.js

@@ -90,13 +90,13 @@ function createTestCmdLine(options) {
 testCmd+='ulimit -c 0 && ';
 }
 
-testCmd+=process.argv[0];
+testCmd+=`"${process.argv[0]}"`;
 
 if(options&&options.withAbortOnUncaughtException){
 testCmd+=' --abort-on-uncaught-exception';
 }
 
-testCmd+=` ${process.argv[1]} child`;
+testCmd+=` "${process.argv[1]}" child`;
 
 returntestCmd;
 }

test/parallel/test-domain-with-abort-on-uncaught-exception.js

@@ -103,8 +103,8 @@ if (process.argv[2] === 'child') {
 if(options.useTryCatch)
 useTryCatchOpt='useTryCatch';
 
-cmdToExec+=`${process.argv[0]}${cmdLineOption ? cmdLineOption : ''}${
-process.argv[1]} child ${throwInDomainErrHandlerOpt}${useTryCatchOpt}`;
+cmdToExec+=`"${process.argv[0]}"${cmdLineOption ? cmdLineOption : ''}"${
+process.argv[1]}" child ${throwInDomainErrHandlerOpt}${useTryCatchOpt}`;
 
 constchild=exec(cmdToExec);
 

test/parallel/test-env-var-no-warnings.js

@@ -7,7 +7,7 @@ if (process.argv[2] === 'child') {
 process.emitWarning('foo');
 }else{
 functiontest(env){
-constcmd=`${process.execPath}${__filename} child`;
+constcmd=`"${process.execPath}" "${__filename}" child`;
 
 cp.exec(cmd,{ env },common.mustCall((err,stdout,stderr)=>{
 assert.strictEqual(err,null);

test/parallel/test-http-chunk-problem.js

@@ -42,13 +42,13 @@ const filename = require('path').join(common.tmpDir, 'big');
 letserver;
 
 functionexecuteRequest(cb){
-cp.exec([process.execPath,
-__filename,
+cp.exec([`"${process.execPath}"`,
+`"${__filename}"`,
 'request',
 server.address().port,
 '|',
-process.execPath,
-__filename,
+`"${process.execPath}"`,
+`"${__filename}"`,
 'shasum'].join(' '),
 (err,stdout,stderr)=>{
 if(err)throwerr;