assert,util: lazy load comparison functions

PR-URL: #20567
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Author: BridgeAR

lib/assert.js

@@ -21,10 +21,6 @@
 'use strict';
 
 const{ Buffer }=require('buffer');
-const{
- isDeepEqual,
- isDeepStrictEqual
-}=require('internal/util/comparisons');
 const{codes: {
 ERR_AMBIGUOUS_ARGUMENT,
 ERR_INVALID_ARG_TYPE,
@@ -36,6 +32,15 @@ const { inspect, types: { isPromise, isRegExp } } = require('util');
 const{EOL}=require('internal/constants');
 const{ NativeModule }=require('internal/bootstrap/loaders');
 
+letisDeepEqual;
+letisDeepStrictEqual;
+
+functionlazyLoadComparison(){
+constcomparison=require('internal/util/comparisons');
+isDeepEqual=comparison.isDeepEqual;
+isDeepStrictEqual=comparison.isDeepStrictEqual;
+}
+
 // Escape control characters but not \n and \t to keep the line breaks and
 // indentation intact.
 // eslint-disable-next-line no-control-regex
@@ -284,6 +289,7 @@ assert.notEqual = function notEqual(actual, expected, message) {
 
 // The equivalence assertion tests a deep equality relation.
 assert.deepEqual=functiondeepEqual(actual,expected,message){
+if(isDeepEqual===undefined)lazyLoadComparison();
 if(!isDeepEqual(actual,expected)){
 innerFail({
  actual,
@@ -297,6 +303,7 @@ assert.deepEqual = function deepEqual(actual, expected, message) {
 
 // The non-equivalence assertion tests for any deep inequality.
 assert.notDeepEqual=functionnotDeepEqual(actual,expected,message){
+if(isDeepEqual===undefined)lazyLoadComparison();
 if(isDeepEqual(actual,expected)){
 innerFail({
  actual,
@@ -310,6 +317,7 @@ assert.notDeepEqual = function notDeepEqual(actual, expected, message) {
 /* eslint-enable */
 
 assert.deepStrictEqual=functiondeepStrictEqual(actual,expected,message){
+if(isDeepEqual===undefined)lazyLoadComparison();
 if(!isDeepStrictEqual(actual,expected)){
 innerFail({
  actual,
@@ -323,6 +331,7 @@ assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
 
 assert.notDeepStrictEqual=notDeepStrictEqual;
 functionnotDeepStrictEqual(actual,expected,message){
+if(isDeepEqual===undefined)lazyLoadComparison();
 if(isDeepStrictEqual(actual,expected)){
 innerFail({
  actual,
@@ -439,6 +448,7 @@ function expectedException(actual, expected, msg) {
 if(expectedinstanceofError){
 keys.push('name','message');
 }
+if(isDeepEqual===undefined)lazyLoadComparison();
 for(constkeyofkeys){
 if(typeofactual[key]==='string'&&
 isRegExp(expected[key])&&

lib/util.js

@@ -64,10 +64,6 @@ const {
  isTypedArray
 }=types;
 
-const{
- isDeepStrictEqual
-}=require('internal/util/comparisons');
-
 const{
  customInspectSymbol,
  deprecate,
@@ -95,6 +91,7 @@ const dateToISOString = Date.prototype.toISOString;
 consterrorToString=Error.prototype.toString;
 
 letCIRCULAR_ERROR_MESSAGE;
+letinternalDeepEqual;
 
 /* eslint-disable */
 conststrEscapeSequencesRegExp=/[\x00-\x1f\x27\x5c]/;
@@ -1261,7 +1258,13 @@ module.exports = exports = {
 isArray: Array.isArray,
  isBoolean,
  isBuffer,
- isDeepStrictEqual,
+isDeepStrictEqual(a,b){
+if(internalDeepEqual===undefined){
+internalDeepEqual=require('internal/util/comparisons')
+.isDeepStrictEqual;
+}
+returninternalDeepEqual(a,b);
+},
  isNull,
  isNullOrUndefined,
  isNumber,