Skip to content

Commit 761caec

Browse files
committed
events: preset usingDomains to false
The line setting this was removed in a previous commit. This potentially breaks code in the wild using this property. Refs: #17403 (comment) PR-URL: #18944 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent 927c1b1 commit 761caec

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

‎lib/events.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ module.exports = EventEmitter;
3131
// Backwards-compat with node 0.10.x
3232
EventEmitter.EventEmitter=EventEmitter;
3333

34+
EventEmitter.usingDomains=false;
35+
3436
EventEmitter.prototype._events=undefined;
3537
EventEmitter.prototype._eventsCount=0;
3638
EventEmitter.prototype._maxListeners=undefined;

‎test/parallel/test-event-emitter-subclass.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ function MyEE(cb) {
3636

3737
constmyee=newMyEE(common.mustCall());
3838

39+
myee.hasOwnProperty('usingDomains');
3940

4041
util.inherits(ErrorEE,EventEmitter);
4142
functionErrorEE(){

0 commit comments

Comments
 (0)