stream: finished should complete with read-only Duplex

If passed a Duplex where readable or writable has been
explicitly disabled then don't assume 'close' will be
emitted.
Fixes: #32965
PR-URL: #32967
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mathias Buus <mathiasbuus@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

Author: ronag

lib/internal/streams/end-of-stream.js

@@ -76,7 +76,9 @@ function eos(stream, opts, callback) {
 state&&
 state.autoDestroy&&
 state.emitClose&&
-state.closed===false
+state.closed===false&&
+isReadable(stream)===readable&&
+isWritable(stream)===writable
 );
 
 letwritableFinished=stream.writableFinished||

test/parallel/test-stream-finished.js

@@ -1,7 +1,7 @@
 'use strict';
 
 constcommon=require('../common');
-const{ Writable, Readable, Transform, finished }=require('stream');
+const{ Writable, Readable, Transform, finished, Duplex}=require('stream');
 constassert=require('assert');
 constEE=require('events');
 constfs=require('fs');
@@ -352,3 +352,35 @@ testClosed((opts) => new Writable({ write() {}, ...opts }));
 r.push(null);
 r.destroy();
 }
+
+{
+constd=newDuplex({
+final(cb){},// Never close writable side for test purpose
+read(){
+this.push(null);
+}
+});
+
+d.on('end',common.mustCall());
+
+finished(d,{readable: true,writable: false},common.mustCall());
+
+d.end();
+d.resume();
+}
+
+{
+constd=newDuplex({
+final(cb){},// Never close writable side for test purpose
+read(){
+this.push(null);
+}
+});
+
+d.on('end',common.mustCall());
+
+d.end();
+finished(d,{readable: true,writable: false},common.mustCall());
+
+d.resume();
+}