Skip to content

Commit 7682e7e

Browse files
targosRafaelGSS
authored andcommitted
test: skip wasm allocation tests in workers
Refs: #62870 PR-URL: #61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> (cherry picked from commit fcff458)
1 parent 79262ff commit 7682e7e

2 files changed

Lines changed: 28 additions & 3 deletions

File tree

‎test/wasm-allocation/test-wasm-allocation-memory64.js‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,19 @@
44
// wasm memory64 with guard regions reserves 16GB of virtual address space.
55
'use strict';
66

7-
require('../common');
7+
constcommon=require('../common');
88
constassert=require('assert');
9+
const{ isMainThread }=require('worker_threads');
910

1011
// The first allocation should succeed.
1112
constfirst=newWebAssembly.Memory({address: 'i64',initial: 10n,maximum: 100n});
1213
assert(first);
1314

15+
if(!isMainThread){
16+
// https://github.com/nodejs/node/issues/62870
17+
common.skip('Workers terminate instead of throwing');
18+
}
19+
1420
// Subsequent allocations should eventually fail due to running out of
1521
// virtual address space. memory64 reserves 16GB per allocation (vs 8GB for
1622
// memory32), so the limit is reached even faster.

‎test/wasm-allocation/test-wasm-allocation.js‎

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,24 @@
44
// wasm memory32 with guard regions reserves 8GB of virtual address space.
55
'use strict';
66

7-
require('../common');
8-
newWebAssembly.Memory({initial: 10,maximum: 100});
7+
constcommon=require('../common');
8+
constassert=require('assert');
9+
const{ isMainThread }=require('worker_threads');
10+
11+
// The first allocation should succeed.
12+
constfirst=newWebAssembly.Memory({initial: 10,maximum: 100});
13+
assert(first);
14+
15+
if(!isMainThread){
16+
// https://github.com/nodejs/node/issues/62870
17+
common.skip('Workers terminate instead of throwing');
18+
}
19+
20+
// Subsequent allocations should eventually fail due to running out of
21+
// virtual address space.
22+
assert.throws(()=>{
23+
constinstances=[first];
24+
for(leti=1;i<30;i++){
25+
instances.push(newWebAssembly.Memory({initial: 10,maximum: 100}));
26+
}
27+
},/WebAssembly\.Memory/);

0 commit comments

Comments
 (0)