fs: only operate on buffers in rimraf

PR-URL: #30569
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: cjihrig

lib/internal/fs/rimraf.js

@@ -11,6 +11,7 @@ const {
  Set,
 }=primordials;
 
+const{ Buffer }=require('buffer');
 const{
  chmod,
  chmodSync,
@@ -25,7 +26,7 @@ const {
  unlink,
  unlinkSync
 }=require('fs');
-const{join}=require('path');
+const{sep}=require('path');
 const{ setTimeout }=require('timers');
 const{ sleep }=require('internal/util');
 constnotEmptyErrorCodes=newSet(['ENOTEMPTY','EEXIST','EPERM']);
@@ -34,6 +35,8 @@ const retryErrorCodes = new Set(
 constisWindows=process.platform==='win32';
 constepermHandler=isWindows ? fixWinEPERM : _rmdir;
 constepermHandlerSync=isWindows ? fixWinEPERMSync : _rmdirSync;
+constreaddirEncoding='buffer';
+constseparator=Buffer.from(sep);
 
 
 functionrimraf(path,options,callback){
@@ -122,7 +125,9 @@ function _rmdir(path, options, originalErr, callback) {
 
 
 function_rmchildren(path,options,callback){
-readdir(path,(err,files)=>{
+constpathBuf=Buffer.from(path);
+
+readdir(pathBuf,readdirEncoding,(err,files)=>{
 if(err)
 returncallback(err);
 
@@ -134,7 +139,9 @@ function _rmchildren(path, options, callback) {
 letdone=false;
 
 files.forEach((child)=>{
-rimraf(join(path,child),options,(err)=>{
+constchildPath=Buffer.concat([pathBuf,separator,child]);
+
+rimraf(childPath,options,(err)=>{
 if(done)
 return;
 
@@ -211,8 +218,12 @@ function _rmdirSync(path, options, originalErr) {
 // original removal. Windows has a habit of not closing handles promptly
 // when files are deleted, resulting in spurious ENOTEMPTY failures. Work
 // around that issue by retrying on Windows.
-readdirSync(path).forEach((child)=>{
-rimrafSync(join(path,child),options);
+constpathBuf=Buffer.from(path);
+
+readdirSync(pathBuf,readdirEncoding).forEach((child)=>{
+constchildPath=Buffer.concat([pathBuf,separator,child]);
+
+rimrafSync(childPath,options);
 });
 
 consttries=options.maxRetries+1;