fs: filehandle read now accepts object as argument

PR-URL: #34180Fixes: #34176
Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: branisha

lib/internal/fs/promises.js

@@ -346,8 +346,19 @@ async function open(path, flags, mode) {
 flagsNumber,mode,kUsePromises));
 }
 
-asyncfunctionread(handle,buffer,offset,length,position){
-validateBuffer(buffer);
+asyncfunctionread(handle,bufferOrOptions,offset,length,position){
+letbuffer=bufferOrOptions;
+if(!isArrayBufferView(buffer)){
+if(bufferOrOptions.buffer){
+buffer=bufferOrOptions.buffer;
+validateBuffer(buffer);
+}else{
+buffer=Buffer.alloc(16384);
+}
+offset=bufferOrOptions.offset||0;
+length=buffer.length;
+position=bufferOrOptions.position||null;
+}
 
 if(offset==null){
 offset=0;

test/parallel/test-fs-promises-file-handle-read.js

@@ -13,7 +13,11 @@ const tmpdir = require('../common/tmpdir');
 constassert=require('assert');
 consttmpDir=tmpdir.path;
 
-tmpdir.refresh();
+asyncfunctionread(fileHandle,buffer,offset,length,position){
+returnuseConf ?
+fileHandle.read({ buffer, offset, length, position }) :
+fileHandle.read(buffer,offset,length,position);
+}
 
 asyncfunctionvalidateRead(){
 constfilePath=path.resolve(tmpDir,'tmp-read-file.txt');
@@ -23,7 +27,7 @@ async function validateRead() {
 constfd=fs.openSync(filePath,'w+');
 fs.writeSync(fd,buffer,0,buffer.length);
 fs.closeSync(fd);
-constreadAsyncHandle=awaitfileHandle.read(Buffer.alloc(11),0,11,0);
+constreadAsyncHandle=awaitread(fileHandle,Buffer.alloc(11),0,11,0);
 assert.deepStrictEqual(buffer.length,readAsyncHandle.bytesRead);
 assert.deepStrictEqual(buffer,readAsyncHandle.buffer);
 
@@ -38,7 +42,7 @@ async function validateEmptyRead() {
 constfd=fs.openSync(filePath,'w+');
 fs.writeSync(fd,buffer,0,buffer.length);
 fs.closeSync(fd);
-constreadAsyncHandle=awaitfileHandle.read(Buffer.alloc(11),0,11,0);
+constreadAsyncHandle=awaitread(fileHandle,Buffer.alloc(11),0,11,0);
 assert.deepStrictEqual(buffer.length,readAsyncHandle.bytesRead);
 
 awaitfileHandle.close();
@@ -51,12 +55,21 @@ async function validateLargeRead() {
 constfilePath=fixtures.path('x.txt');
 constfileHandle=awaitopen(filePath,'r');
 constpos=0xffffffff+1;// max-uint32 + 1
-constreadHandle=awaitfileHandle.read(Buffer.alloc(1),0,1,pos);
+constreadHandle=awaitread(fileHandle,Buffer.alloc(1),0,1,pos);
 
 assert.strictEqual(readHandle.bytesRead,0);
 }
 
-validateRead()
-.then(validateEmptyRead)
-.then(validateLargeRead)
-.then(common.mustCall());
+letuseConf=false;
+
+(asyncfunction(){
+for(constvalueof[false,true]){
+tmpdir.refresh();
+useConf=value;
+
+awaitvalidateRead()
+.then(validateEmptyRead)
+.then(validateLargeRead)
+.then(common.mustCall());
+}
+});