util: enforce shouldColorize in styleText array arg

PR-URL: #56722Fixes: #56717
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Author: marco-ippolito

lib/util.js

@@ -119,6 +119,7 @@ function styleText(format, text, { validateStream = true, stream = process.stdou
 validateString(text,'text');
 validateBoolean(validateStream,'options.validateStream');
 
+letskipColorize;
 if(validateStream){
 if(
 !isReadableStream(stream)&&
@@ -127,40 +128,28 @@ function styleText(format, text, { validateStream = true, stream = process.stdou
 ){
 thrownewERR_INVALID_ARG_TYPE('stream',['ReadableStream','WritableStream','Stream'],stream);
 }
-}
-
-if(ArrayIsArray(format)){
-letleft='';
-letright='';
-for(constkeyofformat){
-constformatCodes=inspect.colors[key];
-if(formatCodes==null){
-validateOneOf(key,'format',ObjectKeys(inspect.colors));
-}
-left+=escapeStyleCode(formatCodes[0]);
-right=`${escapeStyleCode(formatCodes[1])}${right}`;
-}
 
-return`${left}${text}${right}`;
+// If the stream is falsy or should not be colorized, set skipColorize to true
+skipColorize=!lazyUtilColors().shouldColorize(stream);
 }
 
-constformatCodes=inspect.colors[format];
-if(formatCodes==null){
-validateOneOf(format,'format',ObjectKeys(inspect.colors));
-}
+// If the format is not an array, convert it to an array
+constformatArray=ArrayIsArray(format) ? format : [format];
 
-// Check colorize only after validating arg type and value
-if(
-validateStream&&
-(
-!stream||
-!lazyUtilColors().shouldColorize(stream)
-)
-){
-returntext;
+letleft='';
+letright='';
+for(constkeyofformatArray){
+constformatCodes=inspect.colors[key];
+// If the format is not a valid style, throw an error
+if(formatCodes==null){
+validateOneOf(key,'format',ObjectKeys(inspect.colors));
+}
+if(skipColorize)continue;
+left+=escapeStyleCode(formatCodes[0]);
+right=`${escapeStyleCode(formatCodes[1])}${right}`;
 }
 
-return`${escapeStyleCode(formatCodes[0])}${text}${escapeStyleCode(formatCodes[1])}`;
+returnskipColorize ? text : `${left}${text}${right}`;
 }
 
 /**

test/parallel/test-util-styletext.js

@@ -95,8 +95,15 @@ if (fd !== -1) {
  ...process.env,
  ...testCase.env
 };
-constoutput=util.styleText('red','test',{stream: writeStream});
-assert.strictEqual(output,testCase.expected);
+{
+constoutput=util.styleText('red','test',{stream: writeStream});
+assert.strictEqual(output,testCase.expected);
+}
+{
+// Check that when passing an array of styles, the output behaves the same
+constoutput=util.styleText(['red'],'test',{stream: writeStream});
+assert.strictEqual(output,testCase.expected);
+}
 process.env=originalEnv;
 });
 }else{