test: add regex check in test-url-parse-invalid-input

andreicioromila · lpinca · commit 7906ed50fab6 · 2017-05-16T12:10:37.000+02:00
Use a regex to validate the error message. PR-URL: #12879 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-url-parse-invalid-input.js b/test/parallel/test-url-parse-invalid-input.js
@@ -12,9 +12,13 @@ const url = require('url');
 0.0,
 0,
 [],
- {}
-].forEach(function(val) {
- assert.throws(function() { url.parse(val); }, TypeError);
+ {},
+ () => {},
+ Symbol('foo')
+].forEach((val) => {
+ assert.throws(() => { url.parse(val); },
+ /^TypeError: Parameter "url" must be a string, not (undefined|boolean|number|object|function|symbol)$/);
 });
 
-assert.throws(function() { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/);
+assert.throws(() => { url.parse('http://%E0%A4%A@fail'); },
+ /^URIError: URI malformed$/);

-Original file line number
+Diff line change
 .0,
 ,
 [],
 -{}
 -].forEach(function(val){
 -assert.throws(function(){url.parse(val);},TypeError);
 +{},
 +()=>{},
 +Symbol('foo')
 +].forEach((val)=>{
 +assert.throws(()=>{url.parse(val);},
 +/^TypeError:Parameter"url"mustbeastring,not(undefined|boolean|number|object|function|symbol)$/);
 });
 -assert.throws(function(){url.parse('http://%E0%A4%A@fail');},/^URIError:URImalformed$/);
 +assert.throws(()=>{url.parse('http://%E0%A4%A@fail');},
 +/^URIError:URImalformed$/);