lib: enforce use of Array from primordials

PR-URL: #30635
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Author: targos

lib/.eslintrc.yaml

@@ -9,6 +9,8 @@ rules:
  - groups: [[ "&&", "||" ]]
 no-restricted-globals:
  - error
+ - name: Array
+message: "Use `const { Array } = primordials;` instead of the global."
  - name: JSON
 message: "Use `const { JSON } = primordials;` instead of the global."
  - name: Math

lib/_http_client.js

@@ -22,6 +22,7 @@
 'use strict';
 
 const{
+ ArrayIsArray,
  ObjectAssign,
  ObjectKeys,
  ObjectSetPrototypeOf,
@@ -218,7 +219,7 @@ function ClientRequest(input, options, cb) {
 }
 }
 
-constheadersArray=Array.isArray(options.headers);
+constheadersArray=ArrayIsArray(options.headers);
 if(!headersArray){
 if(options.headers){
 constkeys=ObjectKeys(options.headers);

lib/_http_outgoing.js

@@ -22,6 +22,7 @@
 'use strict';
 
 const{
+ ArrayIsArray,
  ObjectCreate,
  ObjectDefineProperty,
  ObjectKeys,
@@ -350,7 +351,7 @@ function _storeHeader(firstLine, headers) {
 constentry=headers[key];
 processHeader(this,state,entry[0],entry[1],false);
 }
-}elseif(Array.isArray(headers)){
+}elseif(ArrayIsArray(headers)){
 for(constentryofheaders){
 processHeader(this,state,entry[0],entry[1],true);
 }
@@ -444,7 +445,7 @@ function _storeHeader(firstLine, headers) {
 functionprocessHeader(self,state,key,value,validate){
 if(validate)
 validateHeaderName(key);
-if(Array.isArray(value)){
+if(ArrayIsArray(value)){
 if(value.length<2||!isCookieField(key)){
 for(vari=0;i<value.length;i++)
 storeHeader(self,state,key,value[i],validate);
@@ -686,7 +687,7 @@ function connectionCorkNT(conn) {
 OutgoingMessage.prototype.addTrailers=functionaddTrailers(headers){
 this._trailer='';
 constkeys=ObjectKeys(headers);
-constisArray=Array.isArray(headers);
+constisArray=ArrayIsArray(headers);
 varfield,value;
 for(vari=0,l=keys.length;i<l;i++){
 varkey=keys[i];

lib/_stream_readable.js

@@ -22,6 +22,7 @@
 'use strict';
 
 const{
+ ArrayIsArray,
  ObjectDefineProperty,
  ObjectSetPrototypeOf,
 }=primordials;
@@ -70,7 +71,7 @@ function prependListener(emitter, event, fn) {
 // the prependListener() method. The goal is to eventually remove this hack.
 if(!emitter._events||!emitter._events[event])
 emitter.on(event,fn);
-elseif(Array.isArray(emitter._events[event]))
+elseif(ArrayIsArray(emitter._events[event]))
 emitter._events[event].unshift(fn);
 else
 emitter._events[event]=[fn,emitter._events[event]];

lib/_stream_writable.js

@@ -26,6 +26,7 @@
 'use strict';
 
 const{
+ Array,
  ObjectDefineProperty,
  ObjectSetPrototypeOf,
 }=primordials;

lib/_tls_common.js

@@ -22,6 +22,7 @@
 'use strict';
 
 const{
+ ArrayIsArray,
  ObjectCreate,
 }=primordials;
 
@@ -105,7 +106,7 @@ exports.createSecureContext = function createSecureContext(options) {
 // Add CA before the cert to be able to load cert's issuer in C++ code.
 const{ ca }=options;
 if(ca){
-if(Array.isArray(ca)){
+if(ArrayIsArray(ca)){
 for(i=0;i<ca.length;++i){
 val=ca[i];
 validateKeyOrCertOption('ca',val);
@@ -121,7 +122,7 @@ exports.createSecureContext = function createSecureContext(options) {
 
 const{ cert }=options;
 if(cert){
-if(Array.isArray(cert)){
+if(ArrayIsArray(cert)){
 for(i=0;i<cert.length;++i){
 val=cert[i];
 validateKeyOrCertOption('cert',val);
@@ -140,7 +141,7 @@ exports.createSecureContext = function createSecureContext(options) {
 constkey=options.key;
 constpassphrase=options.passphrase;
 if(key){
-if(Array.isArray(key)){
+if(ArrayIsArray(key)){
 for(i=0;i<key.length;++i){
 val=key[i];
 // eslint-disable-next-line eqeqeq
@@ -240,7 +241,7 @@ exports.createSecureContext = function createSecureContext(options) {
 }
 
 if(options.crl){
-if(Array.isArray(options.crl)){
+if(ArrayIsArray(options.crl)){
 for(i=0;i<options.crl.length;i++){
 c.context.addCRL(options.crl[i]);
 }
@@ -257,7 +258,7 @@ exports.createSecureContext = function createSecureContext(options) {
 if(!toBuf)
 toBuf=require('internal/crypto/util').toBuf;
 
-if(Array.isArray(options.pfx)){
+if(ArrayIsArray(options.pfx)){
 for(i=0;i<options.pfx.length;i++){
 constpfx=options.pfx[i];
 constraw=pfx.buf ? pfx.buf : pfx;

lib/buffer.js

@@ -22,6 +22,8 @@
 'use strict';
 
 const{
+ Array,
+ ArrayIsArray,
  MathFloor,
  MathMin,
  MathTrunc,
@@ -483,7 +485,7 @@ function fromObject(obj) {
 returnfromArrayLike(obj);
 }
 
-if(obj.type==='Buffer'&&Array.isArray(obj.data)){
+if(obj.type==='Buffer'&&ArrayIsArray(obj.data)){
 returnfromArrayLike(obj.data);
 }
 }
@@ -518,7 +520,7 @@ Buffer[kIsEncodingSymbol] = Buffer.isEncoding;
 
 Buffer.concat=functionconcat(list,length){
 leti;
-if(!Array.isArray(list)){
+if(!ArrayIsArray(list)){
 thrownewERR_INVALID_ARG_TYPE('list','Array',list);
 }
 

lib/child_process.js

@@ -22,6 +22,7 @@
 'use strict';
 
 const{
+ ArrayIsArray,
  ObjectAssign,
  ObjectDefineProperty,
  ObjectPrototypeHasOwnProperty,
@@ -63,7 +64,7 @@ function fork(modulePath /* , args, options */) {
 letoptions={};
 letargs=[];
 letpos=1;
-if(pos<arguments.length&&Array.isArray(arguments[pos])){
+if(pos<arguments.length&&ArrayIsArray(arguments[pos])){
 args=arguments[pos++];
 }
 
@@ -96,7 +97,7 @@ function fork(modulePath /* , args, options */) {
 
 if(typeofoptions.stdio==='string'){
 options.stdio=stdioStringToArray(options.stdio,'ipc');
-}elseif(!Array.isArray(options.stdio)){
+}elseif(!ArrayIsArray(options.stdio)){
 // Use a separate fd=3 for the IPC channel. Inherit stdin, stdout,
 // and stderr from the parent if silent isn't set.
 options.stdio=stdioStringToArray(
@@ -186,7 +187,7 @@ function execFile(file /* , args, options, callback */) {
 
 // Parse the optional positional parameters.
 letpos=1;
-if(pos<arguments.length&&Array.isArray(arguments[pos])){
+if(pos<arguments.length&&ArrayIsArray(arguments[pos])){
 args=arguments[pos++];
 }elseif(pos<arguments.length&&arguments[pos]==null){
 pos++;
@@ -404,7 +405,7 @@ function normalizeSpawnArguments(file, args, options) {
 if(file.length===0)
 thrownewERR_INVALID_ARG_VALUE('file',file,'cannot be empty');
 
-if(Array.isArray(args)){
+if(ArrayIsArray(args)){
 args=args.slice(0);
 }elseif(args==null){
 args=[];

lib/dgram.js

@@ -22,6 +22,8 @@
 'use strict';
 
 const{
+ Array,
+ ArrayIsArray,
  ObjectDefineProperty,
  ObjectSetPrototypeOf,
 }=primordials;
@@ -592,7 +594,7 @@ Socket.prototype.send = function(buffer,
 thrownewERR_SOCKET_DGRAM_IS_CONNECTED();
 }
 
-if(!Array.isArray(buffer)){
+if(!ArrayIsArray(buffer)){
 if(typeofbuffer==='string'){
 list=[Buffer.from(buffer)];
 }elseif(!isUint8Array(buffer)){

lib/domain.js

@@ -27,6 +27,7 @@
 // unless they address existing, critical bugs.
 
 const{
+ Array,
  ObjectDefineProperty,
  ReflectApply,
 }=primordials;