assert: fix CallTracker wraps the function causes the length to be lost

PR-URL: #42909Fixes: #40484
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: Y1D7NG

lib/internal/assert/calltracker.js

@@ -4,6 +4,7 @@ const {
  ArrayPrototypePush,
  Error,
  FunctionPrototype,
+ Proxy,
  ReflectApply,
  SafeSet,
 }=primordials;
@@ -46,20 +47,23 @@ class CallTracker {
 constcallChecks=this.#callChecks;
 callChecks.add(context);
 
-returnfunction(){
-context.actual++;
-if(context.actual===context.exact){
-// Once function has reached its call count remove it from
-// callChecks set to prevent memory leaks.
-callChecks.delete(context);
-}
-// If function has been called more than expected times, add back into
-// callchecks.
-if(context.actual===context.exact+1){
-callChecks.add(context);
-}
-returnReflectApply(fn,this,arguments);
-};
+returnnewProxy(fn,{
+__proto__: null,
+apply(fn,thisArg,argList){
+context.actual++;
+if(context.actual===context.exact){
+// Once function has reached its call count remove it from
+// callChecks set to prevent memory leaks.
+callChecks.delete(context);
+}
+// If function has been called more than expected times, add back into
+// callchecks.
+if(context.actual===context.exact+1){
+callChecks.add(context);
+}
+returnReflectApply(fn,thisArg,argList);
+},
+});
 }
 
 report(){

test/parallel/test-assert-calltracker-calls.js

@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 
 // This test ensures that assert.CallTracker.calls() works as intended.
@@ -78,3 +78,51 @@ assert.throws(
 callsNoop();
 tracker.verify();
 }
+
+{
+functionfunc(){}
+consttracker=newassert.CallTracker();
+constcallsfunc=tracker.calls(func);
+assert.strictEqual(callsfunc.length,0);
+}
+
+{
+functionfunc(a,b,c=2){}
+consttracker=newassert.CallTracker();
+constcallsfunc=tracker.calls(func);
+assert.strictEqual(callsfunc.length,2);
+}
+
+{
+functionfunc(a,b,c=2){}
+deletefunc.length;
+consttracker=newassert.CallTracker();
+constcallsfunc=tracker.calls(func);
+assert.strictEqual(Object.hasOwn(callsfunc,'length'),false);
+}
+
+{
+constArrayIteratorPrototype=Reflect.getPrototypeOf(
+Array.prototype.values()
+);
+const{ next }=ArrayIteratorPrototype;
+ArrayIteratorPrototype.next=common.mustNotCall(
+'%ArrayIteratorPrototype%.next'
+);
+Object.prototype.get=common.mustNotCall('%Object.prototype%.get');
+
+constcustomPropertyValue=Symbol();
+functionfunc(a,b,c=2){
+returna+b+c;
+}
+func.customProperty=customPropertyValue;
+Object.defineProperty(func,'length',{get: common.mustNotCall()});
+consttracker=newassert.CallTracker();
+constcallsfunc=tracker.calls(func);
+assert.strictEqual(Object.hasOwn(callsfunc,'length'),true);
+assert.strictEqual(callsfunc.customProperty,customPropertyValue);
+assert.strictEqual(callsfunc(1,2,3),6);
+
+ArrayIteratorPrototype.next=next;
+deleteObject.prototype.get;
+}