fs: fix WriteStream autoClose order

WriteStream autoClose was implemented by manually
calling .destroy() instead of using autoDestroy
and callback. This caused some invariants related
to order of events to be broken.
Fixes: #31776
Backport-PR-URL: #32163
PR-URL: #31790
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: ronag

lib/internal/fs/streams.js

@@ -300,6 +300,11 @@ function WriteStream(path, options) {
 options.emitClose=false;
 }
 
+if(options.autoDestroy===undefined){
+options.autoDestroy=options.autoClose===undefined ?
+true : (options.autoClose||false);
+}
+
 this[kFs]=options.fs||fs;
 if(typeofthis[kFs].open!=='function'){
 thrownewERR_INVALID_ARG_TYPE('options.fs.open','function',
@@ -343,7 +348,7 @@ function WriteStream(path, options) {
 this.mode=options.mode===undefined ? 0o666 : options.mode;
 
 this.start=options.start;
-this.autoClose=options.autoClose===undefined ? true : !!options.autoClose;
+this.autoClose=options.autoDestroy;
 this.pos=undefined;
 this.bytesWritten=0;
 this.closed=false;
@@ -371,10 +376,6 @@ WriteStream.prototype._final = function(callback) {
 });
 }
 
-if(this.autoClose){
-this.destroy();
-}
-
 callback();
 };
 
@@ -425,9 +426,6 @@ WriteStream.prototype._write = function(data, encoding, cb) {
 }
 
 if(er){
-if(this.autoClose){
-this.destroy();
-}
 returncb(er);
 }
 this.bytesWritten+=bytes;

test/parallel/test-file-write-stream.js

@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 
 constpath=require('path');
@@ -46,9 +46,9 @@ file
 callbacks.open++;
 assert.strictEqual(typeoffd,'number');
 })
-.on('error',function(err){
-throwerr;
-})
+.on('error',common.mustCall((err)=>{
+assert.strictEqual(err.code,'ERR_STREAM_WRITE_AFTER_END');
+}))
 .on('drain',function(){
 console.error('drain!',callbacks.drain);
 callbacks.drain++;
@@ -61,21 +61,12 @@ file
 }
 })
 .on('close',function(){
-console.error('close!');
 assert.strictEqual(file.bytesWritten,EXPECTED.length*2);
 
 callbacks.close++;
-assert.throws(
-()=>{
-console.error('write after end should not be allowed');
-file.write('should not work anymore');
-},
-{
-code: 'ERR_STREAM_WRITE_AFTER_END',
-name: 'Error',
-message: 'write after end'
-}
-);
+file.write('should not work anymore',common.mustCall((err)=>{
+assert.strictEqual(err.code,'ERR_STREAM_WRITE_AFTER_END');
+}));
 
 fs.unlinkSync(fn);
 });

test/parallel/test-fs-read-stream-autoClose.js

@@ -0,0 +1,16 @@
+'use strict';
+
+constcommon=require('../common');
+constfs=require('fs');
+constpath=require('path');
+constassert=require('assert');
+consttmpdir=require('../common/tmpdir');
+constwriteFile=path.join(tmpdir.path,'write-autoClose.txt');
+tmpdir.refresh();
+
+constfile=fs.createWriteStream(writeFile,{autoClose: true});
+
+file.on('finish',common.mustCall(()=>{
+assert.strictEqual(file.destroyed,false);
+}));
+file.end('asd');

test/parallel/test-fs-write-stream-autoclose-option.js

@@ -27,8 +27,8 @@ function next() {
 stream.end();
 stream.on('finish',common.mustCall(function(){
 assert.strictEqual(stream.closed,false);
-assert.strictEqual(stream.fd,null);
 stream.on('close',common.mustCall(function(){
+assert.strictEqual(stream.fd,null);
 assert.strictEqual(stream.closed,true);
 process.nextTick(next2);
 }));
@@ -51,8 +51,8 @@ function next3() {
 stream.end();
 stream.on('finish',common.mustCall(function(){
 assert.strictEqual(stream.closed,false);
-assert.strictEqual(stream.fd,null);
 stream.on('close',common.mustCall(function(){
+assert.strictEqual(stream.fd,null);
 assert.strictEqual(stream.closed,true);
 }));
 }));