src: remove internalBinding('config').warningFile

Instead use `require('internal/options')` lazily. Also refactor the
call site a bit so that the option is queried only once since it's
synchronous anyway.
PR-URL: #24959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: joyeecheung

lib/internal/process/warning.js

@@ -1,11 +1,18 @@
 'use strict';
 
-constconfig=internalBinding('config');
 constprefix=`(${process.release.name}:${process.pid}) `;
 const{ERR_INVALID_ARG_TYPE}=require('internal/errors').codes;
 
 exports.setup=setupProcessWarnings;
 
+letoptions;
+functionlazyOption(name){
+if(!options){
+options=require('internal/options');
+}
+returnoptions.getOptionValue(name);
+}
+
 varcachedFd;
 varacquiringFd=false;
 functionnop(){}
@@ -51,11 +58,11 @@ function onAcquired(message) {
 };
 }
 
-functionacquireFd(cb){
+functionacquireFd(warningFile,cb){
 if(cachedFd===undefined&&!acquiringFd){
 acquiringFd=true;
 if(fs===null)fs=require('fs');
-fs.open(config.warningFile,'a',onOpen(cb));
+fs.open(warningFile,'a',onOpen(cb));
 }elseif(cachedFd!==undefined&&!acquiringFd){
 cb(null,cachedFd);
 }else{
@@ -64,8 +71,9 @@ function acquireFd(cb) {
 }
 
 functionoutput(message){
-if(typeofconfig.warningFile==='string'){
-acquireFd(onAcquired(message));
+constwarningFile=lazyOption('--redirect-warnings');
+if(warningFile){
+acquireFd(warningFile,onAcquired(message));
 return;
 }
 writeOut(message);

src/node_config.cc

@@ -90,11 +90,6 @@ static void Initialize(Local<Object> target,
 "bits",
 Number::New(env->isolate(), 8 * sizeof(intptr_t)));
 
-const std::string& warning_file = env->options()->redirect_warnings;
-if (!warning_file.empty()) {
-READONLY_STRING_PROPERTY(target, "warningFile", warning_file);
- }
-
  Local<Object> debug_options_obj = Object::New(isolate);
 READONLY_PROPERTY(target, "debugOptions", debug_options_obj);