assert: fix loose deepEqual map comparison

BridgeAR · BridgeAR · commit 7fb8d319fa52 · 2018-12-05T20:07:10.000+01:00
Loose map comparison had an logic error. It will now be properly compared. PR-URL: #24749 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -416,9 +416,7 @@ function mapMightHaveLoosePrim(a, b, prim, item, memo) {
 !innerDeepEqual(item, curB, false, memo)) {
 return false;
 }
- const curA = a.get(altValue);
- return curA === undefined && a.has(altValue) ||
- innerDeepEqual(item, curA, false, memo);
+ return !a.has(altValue) && innerDeepEqual(item, curB, false, memo);
 }
 
 function setEquiv(a, b, strict, memo) {
diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js
@@ -394,6 +394,14 @@ assertOnlyDeepEqual(
 new Map([[1, {}]]),
 new Map([[true, {}]])
 );
+assertOnlyDeepEqual(
+ new Map([[undefined, true]]),
+ new Map([[null, true]])
+);
+assertNotDeepOrStrict(
+ new Map([[undefined, true]]),
+ new Map([[true, true]])
+);
 
 // GH-6416. Make sure circular refs don't throw.
 {

Original file line number	Diff line number	Diff line change
`@@ -416,9 +416,7 @@ function mapMightHaveLoosePrim(a, b, prim, item, memo) {`
`416`	`416`	`!innerDeepEqual(item,curB,false,memo)){`
`417`	`417`	`returnfalse;`
`418`	`418`	`}`
`419`		`-constcurA=a.get(altValue);`
`420`		`-returncurA===undefined&&a.has(altValue)\|\|`
`421`		`-innerDeepEqual(item,curA,false,memo);`
	`419`	`+return!a.has(altValue)&&innerDeepEqual(item,curB,false,memo);`
`422`	`420`	`}`
`423`	`421`
`424`	`422`	`functionsetEquiv(a,b,strict,memo){`
-Original file line number
+Diff line change
 newMap([[1,{}]]),
 newMap([[true,{}]])
 );
 +assertOnlyDeepEqual(
 +newMap([[undefined,true]]),
 +newMap([[null,true]])
 +);
 +assertNotDeepOrStrict(
 +newMap([[undefined,true]]),
 +newMap([[true,true]])
 +);
 // GH-6416. Make sure circular refs don't throw.
+{