tools,benchmark,lib,test: enable no-case-declarations lint rule

PR-URL: #41385
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: Trott

.eslintrc.js

@@ -175,6 +175,7 @@ module.exports = {
 }],
 'new-parens': 'error',
 'no-async-promise-executor': 'error',
+'no-case-declarations': 'error',
 'no-class-assign': 'error',
 'no-confusing-arrow': 'error',
 'no-const-assign': 'error',

benchmark/zlib/inflate.js

@@ -16,7 +16,7 @@ function main({ n, method, inputLen }) {
 leti=0;
 switch(method){
 // Performs `n` single inflate operations
-case'inflate':
+case'inflate':{
 constinflate=zlib.inflate;
 bench.start();
 (functionnext(err,result){
@@ -25,14 +25,16 @@ function main({ n, method, inputLen }) {
 inflate(chunk,next);
 })();
 break;
+}
 // Performs `n` single inflateSync operations
-case'inflateSync':
+case'inflateSync':{
 constinflateSync=zlib.inflateSync;
 bench.start();
 for(;i<n;++i)
 inflateSync(chunk);
 bench.end(n);
 break;
+}
 default:
 thrownewError('Unsupported inflate method');
 }

lib/_http_server.js

@@ -411,7 +411,7 @@ Server.prototype.setTimeout = function setTimeout(msecs, callback) {
 
 Server.prototype[EE.captureRejectionSymbol]=function(err,event, ...args){
 switch(event){
-case'request':
+case'request':{
 const{1: res}=args;
 if(!res.headersSent&&!res.writableEnded){
 // Don't leak headers.
@@ -425,6 +425,7 @@ Server.prototype[EE.captureRejectionSymbol] = function(err, event, ...args) {
 res.destroy();
 }
 break;
+}
 default:
 net.Server.prototype[SymbolFor('nodejs.rejection')]
 .apply(this,arguments);

lib/internal/bootstrap/switches/is_main_thread.js

@@ -42,20 +42,22 @@ function createWritableStdioStream(fd) {
 letstream;
 // Note stream._type is used for test-module-load-list.js
 switch(guessHandleType(fd)){
-case'TTY':
+case'TTY':{
 consttty=require('tty');
 stream=newtty.WriteStream(fd);
 stream._type='tty';
 break;
+}
 
-case'FILE':
+case'FILE':{
 constSyncWriteStream=require('internal/fs/sync_write_stream');
 stream=newSyncWriteStream(fd,{autoClose: false});
 stream._type='fs';
 break;
+}
 
 case'PIPE':
-case'TCP':
+case'TCP':{
 constnet=require('net');
 
 // If fd is already being used for the IPC channel, libuv will return
@@ -78,8 +80,9 @@ function createWritableStdioStream(fd) {
 
 stream._type='pipe';
 break;
+}
 
-default:
+default:{
 // Provide a dummy black-hole output for e.g. non-console
 // Windows applications.
 const{ Writable }=require('stream');
@@ -88,6 +91,7 @@ function createWritableStdioStream(fd) {
 cb();
 }
 });
+}
 }
 
 // For supporting legacy API we put the FD here.
@@ -147,18 +151,20 @@ function getStdin() {
 constfd=0;
 
 switch(guessHandleType(fd)){
-case'TTY':
+case'TTY':{
 consttty=require('tty');
 stdin=newtty.ReadStream(fd);
 break;
+}
 
-case'FILE':
+case'FILE':{
 constfs=require('fs');
 stdin=newfs.ReadStream(null,{fd: fd,autoClose: false});
 break;
+}
 
 case'PIPE':
-case'TCP':
+case'TCP':{
 constnet=require('net');
 
 // It could be that process has been started with an IPC channel
@@ -183,13 +189,15 @@ function getStdin() {
 // Make sure the stdin can't be `.end()`-ed
 stdin._writableState.ended=true;
 break;
+}
 
-default:
+default:{
 // Provide a dummy contentless input for e.g. non-console
 // Windows applications.
 const{ Readable }=require('stream');
 stdin=newReadable({read(){}});
 stdin.push(null);
+}
 }
 
 // For supporting legacy API we put the FD here.

lib/internal/crypto/aes.js

@@ -189,7 +189,7 @@ function asyncAesGcmCipher(
 consttagByteLength=MathFloor(tagLength/8);
 lettag;
 switch(mode){
-casekWebCryptoCipherDecrypt:
+casekWebCryptoCipherDecrypt:{
 constslice=ArrayBufferIsView(data) ?
 TypedArrayPrototypeSlice : ArrayBufferPrototypeSlice;
 tag=slice(data,-tagByteLength);
@@ -206,6 +206,7 @@ function asyncAesGcmCipher(
 
 data=slice(data,0,-tagByteLength);
 break;
+}
 casekWebCryptoCipherEncrypt:
 tag=tagByteLength;
 break;

lib/internal/crypto/webcrypto.js

@@ -427,7 +427,7 @@ async function importGenericSecretKey(
 
 break;
 }
-case'raw':
+case'raw':{
 if(hasAnyNotIn(usagesSet,['deriveKey','deriveBits'])){
 throwlazyDOMException(
 `Unsupported key usage for a ${name} key`,
@@ -449,6 +449,7 @@ async function importGenericSecretKey(
 
 constkeyObject=createSecretKey(keyData);
 returnnewInternalCryptoKey(keyObject,{ name },keyUsages,false);
+}
 }
 
 throwlazyDOMException(

lib/internal/error_serdes.js

@@ -120,21 +120,23 @@ let deserialize;
 functiondeserializeError(error){
 if(!deserialize)deserialize=require('v8').deserialize;
 switch(error[0]){
-casekSerializedError:
+casekSerializedError:{
 const{ constructor, properties }=deserialize(error.subarray(1));
 constctor=errors[constructor];
 ObjectDefineProperty(properties,SymbolToStringTag,{
 value: {value: 'Error',configurable: true},
 enumerable: true
 });
 returnObjectCreate(ctor.prototype,properties);
+}
 casekSerializedObject:
 returndeserialize(error.subarray(1));
-casekInspectedError:
+casekInspectedError:{
 constbuf=Buffer.from(error.buffer,
 error.byteOffset+1,
 error.byteLength-1);
 returnbuf.toString('utf8');
+}
 }
 require('assert').fail('This should not happen');
 }

lib/internal/http2/compat.js

@@ -217,28 +217,31 @@ const proxySocketHandler = {
 case'writable':
 case'destroyed':
 returnstream[prop];
-case'readable':
+case'readable':{
 if(stream.destroyed)
 returnfalse;
 constrequest=stream[kRequest];
 returnrequest ? request.readable : stream.readable;
-case'setTimeout':
+}
+case'setTimeout': {
 constsession=stream.session;
 if(session!==undefined)
 returnFunctionPrototypeBind(session.setTimeout,session);
 returnFunctionPrototypeBind(stream.setTimeout,stream);
+}
 case'write':
 case'read':
 case'pause':
 case'resume':
 thrownewERR_HTTP2_NO_SOCKET_MANIPULATION();
-default:
+default:{
 constref=stream.session!==undefined ?
 stream.session[kSocket] : stream;
 constvalue=ref[prop];
 returntypeofvalue==='function' ?
 FunctionPrototypeBind(value,ref) :
 value;
+}
 }
 },
 getPrototypeOf(stream){
@@ -258,23 +261,25 @@ const proxySocketHandler = {
 case'destroy':
 stream[prop]=value;
 returntrue;
-case'setTimeout':
+case'setTimeout':{
 constsession=stream.session;
 if(session!==undefined)
 session.setTimeout=value;
 else
 stream.setTimeout=value;
 returntrue;
+}
 case'write':
 case'read':
 case'pause':
 case'resume':
 thrownewERR_HTTP2_NO_SOCKET_MANIPULATION();
-default:
+default:{
 constref=stream.session!==undefined ?
 stream.session[kSocket] : stream;
 ref[prop]=value;
 returntrue;
+}
 }
 }
 };

lib/internal/http2/core.js

@@ -867,14 +867,15 @@ const proxySocketHandler = {
 case'setKeepAlive':
 case'setNoDelay':
 thrownewERR_HTTP2_NO_SOCKET_MANIPULATION();
-default:
+default:{
 constsocket=session[kSocket];
 if(socket===undefined)
 thrownewERR_HTTP2_SOCKET_UNBOUND();
 constvalue=socket[prop];
 returntypeofvalue==='function' ?
 FunctionPrototypeBind(value,socket) :
 value;
+}
 }
 },
 getPrototypeOf(session){
@@ -901,12 +902,13 @@ const proxySocketHandler = {
 case'setKeepAlive':
 case'setNoDelay':
 thrownewERR_HTTP2_NO_SOCKET_MANIPULATION();
-default:
+default:{
 constsocket=session[kSocket];
 if(socket===undefined)
 thrownewERR_HTTP2_SOCKET_UNBOUND();
 socket[prop]=value;
 returntrue;
+}
 }
 }
 };
@@ -1558,10 +1560,11 @@ class Http2Session extends EventEmitter {
 
 [EventEmitter.captureRejectionSymbol](err,event, ...args){
 switch(event){
-case'stream':
+case'stream':{
 conststream=args[0];
 stream.destroy(err);
 break;
+}
 default:
 this.destroy(err);
 }
@@ -3184,7 +3187,7 @@ Http2Server.prototype[EventEmitter.captureRejectionSymbol] = function(
 err,event, ...args){
 
 switch(event){
-case'stream':
+case'stream':{
 // TODO(mcollina): we might want to match this with what we do on
 // the compat side.
 const{0: stream}=args;
@@ -3195,7 +3198,8 @@ Http2Server.prototype[EventEmitter.captureRejectionSymbol] = function(
 stream.end();
 }
 break;
-case'request':
+}
+case'request': {
 const{1: res}=args;
 if(!res.headersSent&&!res.finished){
 // Don't leak headers.
@@ -3208,6 +3212,7 @@ Http2Server.prototype[EventEmitter.captureRejectionSymbol] = function(
 res.destroy();
 }
 break;
+}
 default:
 ArrayPrototypeUnshift(args,err,event);
 ReflectApply(net.Server.prototype[EventEmitter.captureRejectionSymbol],

lib/internal/repl/utils.js

@@ -110,14 +110,15 @@ function isRecoverableError(e, code) {
 recoverable=true;
 break;
 
-case'Unterminated string constant':
+case'Unterminated string constant':{
 consttoken=StringPrototypeSlice(this.input,
 this.lastTokStart,this.pos);
 // See https://www.ecma-international.org/ecma-262/#sec-line-terminators
 if(RegExpPrototypeTest(/\\(?:\r\n?|\n|\u2028|\u2029)$/,
 token)){
 recoverable=true;
 }
+}
 }
 super.raise(pos,message);
 }