lib: gbk decoder is gb18030 decoder per spec

ChALkeR · RafaelGSS · commit 8156738b9752 · 2026-01-13T10:04:55.000-03:00
PR-URL: #61099 Refs: https://encoding.spec.whatwg.org/#gbk-decoder Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/internal/encoding.js b/lib/internal/encoding.js
@@ -431,7 +431,9 @@ function makeTextDecoderICU() {
 
 #prepareConverter() {
 if (this[kHandle] !== undefined) return;
- const handle = getConverter(this[kEncoding], this[kFlags]);
+ let icuEncoding = this[kEncoding];
+ if (icuEncoding === 'gbk') icuEncoding = 'gb18030'; // 10.1.1. GBK's decoder is gb18030's decoder
+ const handle = getConverter(icuEncoding, this[kFlags]);
 if (handle === undefined)
 throw new ERR_ENCODING_NOT_SUPPORTED(this[kEncoding]);
 this[kHandle] = handle;

-Original file line number
+Diff line change
  #prepareConverter(){
 if(this[kHandle]!==undefined)return;
 -consthandle=getConverter(this[kEncoding],this[kFlags]);
 +leticuEncoding=this[kEncoding];
 +if(icuEncoding==='gbk')icuEncoding='gb18030';// 10.1.1. GBK's decoder is gb18030's decoder
 +consthandle=getConverter(icuEncoding,this[kFlags]);
 if(handle===undefined)
 thrownewERR_ENCODING_NOT_SUPPORTED(this[kEncoding]);
 this[kHandle]=handle;