crypto: refactor keyObject.toCryptoKey() and SubtleCrypto.getPublicKey()

Move KeyObject.prototype.toCryptoKey() onto the base KeyObject
class and dispatch from the cached native key type. Both secret and
asymmetric conversions now pass a KeyObjectHandle through the Web
Crypto import paths.
Expose KeyObjectHandle.prototype.getKeyType() so asymmetric importers
can validate public/private usages without wrapping the handle back
into a KeyObject. Secret importers likewise consume KeyObjectHandle
directly.
Use the shared asymmetric conversion helper to derive public
CryptoKeys for SubtleCrypto.getPublicKey(), avoiding the temporary
PrivateKeyObject/createPublicKey round trip while keeping usage
validation in the import path.
Update getPublicKey and KeyObject.toCryptoKey tests to be driven from
the Web Crypto supported-algorithm registry so new algorithms require
either coverage or an explicit skip.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63622
Backport-PR-URL: #64629
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: panva

lib/internal/crypto/aes.js

@@ -40,8 +40,6 @@ const {
  InternalCryptoKey,
  getCryptoKeyAlgorithm,
  getCryptoKeyHandle,
- getKeyObjectHandle,
- getKeyObjectSymmetricKeySize,
 }=require('internal/crypto/keys');
 
 const{
@@ -223,10 +221,10 @@ function aesImportKey(
 lethandle;
 letlength;
 switch(format){
-case'KeyObject': {
-length=getKeyObjectSymmetricKeySize(keyData)*8;
+case'KeyObjectHandle': {
+length=keyData.getSymmetricKeySize()*8;
 validateKeyLength(length);
-handle=getKeyObjectHandle(keyData);
+handle=keyData;
 break;
 }
 case'raw-secret':

lib/internal/crypto/cfrg.js

@@ -13,6 +13,7 @@ const {
  kCryptoJobWebCrypto,
  kKeyFormatDER,
  kKeyFormatRawPublic,
+ kKeyTypePublic,
  kSignJobModeSign,
  kSignJobModeVerify,
  kWebCryptoKeyFormatPKCS8,
@@ -39,8 +40,6 @@ const {
 const{
  getCryptoKeyHandle,
  getCryptoKeyType,
- getKeyObjectHandle,
- getKeyObjectType,
  InternalCryptoKey,
 }=require('internal/crypto/keys');
 
@@ -178,12 +177,11 @@ function cfrgImportKey(
 lethandle;
 constusagesSet=newSafeSet(usages);
 switch(format){
-case'KeyObject': {
+case'KeyObjectHandle':
 verifyAcceptableCfrgKeyUse(
-name,getKeyObjectType(keyData)==='public',usagesSet);
-handle=getKeyObjectHandle(keyData);
+name,keyData.getKeyType()===kKeyTypePublic,usagesSet);
+handle=keyData;
 break;
-}
 case'spki': {
 verifyAcceptableCfrgKeyUse(name,true,usagesSet);
 handle=importDerKey(keyData,true);

lib/internal/crypto/chacha20_poly1305.js

@@ -23,7 +23,6 @@ const {
 const{
  InternalCryptoKey,
  getCryptoKeyHandle,
- getKeyObjectHandle,
 }=require('internal/crypto/keys');
 
 const{
@@ -90,8 +89,8 @@ function c20pImportKey(
 
 lethandle;
 switch(format){
-case'KeyObject': {
-handle=getKeyObjectHandle(keyData);
+case'KeyObjectHandle': {
+handle=keyData;
 break;
 }
 case'raw-secret': {

lib/internal/crypto/ec.js

@@ -46,8 +46,6 @@ const {
  getCryptoKeyAlgorithm,
  getCryptoKeyHandle,
  getCryptoKeyType,
- getKeyObjectHandle,
- getKeyObjectType,
 }=require('internal/crypto/keys');
 
 const{
@@ -185,12 +183,11 @@ function ecImportKey(
 lethandle;
 constusagesSet=newSafeSet(usages);
 switch(format){
-case'KeyObject': {
+case'KeyObjectHandle':
 verifyAcceptableEcKeyUse(
-name,getKeyObjectType(keyData)==='public',usagesSet);
-handle=getKeyObjectHandle(keyData);
+name,keyData.getKeyType()===kKeyTypePublic,usagesSet);
+handle=keyData;
 break;
-}
 case'spki': {
 verifyAcceptableEcKeyUse(name,true,usagesSet);
 handle=importDerKey(keyData,true);