stream: pipeline wait for close before calling the callback

The pipeline should wait for close event to finish before calling
the callback.
The `finishCount` should not below 0 when calling finish function.
Fixes: #51540
Co-authored-by: wh0 <wh0@users.noreply.github.com>
PR-URL: #53462
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

Author: 2 people

lib/internal/streams/pipeline.js

@@ -224,6 +224,10 @@ function pipelineImpl(streams, callback, opts) {
 finishImpl(err,--finishCount===0);
 }
 
+functionfinishOnlyHandleError(err){
+finishImpl(err,false);
+}
+
 functionfinishImpl(err,final){
 if(err&&(!error||error.code==='ERR_STREAM_PREMATURE_CLOSE')){
 error=err;
@@ -273,7 +277,7 @@ function pipelineImpl(streams, callback, opts) {
 err.name!=='AbortError'&&
 err.code!=='ERR_STREAM_PREMATURE_CLOSE'
 ){
-finish(err);
+finishOnlyHandleError(err);
 }
 }
 stream.on('error',onError);
@@ -366,7 +370,7 @@ function pipelineImpl(streams, callback, opts) {
 }elseif(isNodeStream(stream)){
 if(isReadableNodeStream(ret)){
 finishCount+=2;
-constcleanup=pipe(ret,stream,finish,{ end });
+constcleanup=pipe(ret,stream,finish,finishOnlyHandleError,{ end });
 if(isReadable(stream)&&isLastStream){
 lastStreamCleanup.push(cleanup);
 }
@@ -409,12 +413,12 @@ function pipelineImpl(streams, callback, opts) {
 returnret;
 }
 
-functionpipe(src,dst,finish,{ end }){
+functionpipe(src,dst,finish,finishOnlyHandleError,{ end }){
 letended=false;
 dst.on('close',()=>{
 if(!ended){
 // Finish if the destination closes before the source has completed.
-finish(newERR_STREAM_PREMATURE_CLOSE());
+finishOnlyHandleError(newERR_STREAM_PREMATURE_CLOSE());
 }
 });
 

test/parallel/test-stream-pipeline.js

@@ -1664,5 +1664,47 @@ const tsp = require('timers/promises');
 pipeline(r,w,common.mustCall((err)=>{
 assert.strictEqual(err,undefined);
 }));
+}
+
+{
+// See https://github.com/nodejs/node/issues/51540 for the following 2 tests
+constsrc=newReadable();
+constdst=newWritable({
+destroy(error,cb){
+// Takes a while to destroy
+setImmediate(cb);
+},
+});
+
+pipeline(src,dst,(err)=>{
+assert.strictEqual(src.closed,true);
+assert.strictEqual(dst.closed,true);
+assert.strictEqual(err.message,'problem');
+});
+src.destroy(newError('problem'));
+}
 
+{
+constsrc=newReadable();
+constdst=newWritable({
+destroy(error,cb){
+// Takes a while to destroy
+setImmediate(cb);
+},
+});
+constpassThroughs=[];
+for(leti=0;i<10;i++){
+passThroughs.push(newPassThrough());
+}
+
+pipeline(src, ...passThroughs,dst,(err)=>{
+assert.strictEqual(src.closed,true);
+assert.strictEqual(dst.closed,true);
+assert.strictEqual(err.message,'problem');
+
+for(leti=0;i<passThroughs.length;i++){
+assert.strictEqual(passThroughs[i].closed,true);
+}
+});
+src.destroy(newError('problem'));
 }