test: improve coverage of SourceTextModule getters

juanarbol · targos · commit 836fba52ea6b · 2021-06-11T09:29:57.000+02:00
PR-URL: #37013 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-vm-module-errors.js b/test/parallel/test-vm-module-errors.js
@@ -235,16 +235,26 @@ function checkInvalidCachedData() {
 }
 
 function checkGettersErrors() {
+ const expectedError = {
+ code: 'ERR_VM_MODULE_NOT_MODULE',
+ message: /Provided module is not an instance of Module/
+ };
 const getters = ['identifier', 'context', 'namespace', 'status', 'error'];
 getters.forEach((getter) => {
 assert.throws(() => {
 // eslint-disable-next-line no-unused-expressions
 Module.prototype[getter];
- }, {
- code: 'ERR_VM_MODULE_NOT_MODULE',
- message: /Provided module is not an instance of Module/
- });
+ }, expectedError);
+ assert.throws(() => {
+ // eslint-disable-next-line no-unused-expressions
+ SourceTextModule.prototype[getter];
+ }, expectedError);
 });
+ // `dependencySpecifiers` getter is just part of SourceTextModule
+ assert.throws(() => {
+ // eslint-disable-next-line no-unused-expressions
+ SourceTextModule.prototype.dependencySpecifiers;
+ }, expectedError);
 }
 
 const finished = common.mustCall();

-Original file line number
+Diff line change
+}
 functioncheckGettersErrors(){
 +constexpectedError={
 +code: 'ERR_VM_MODULE_NOT_MODULE',
 +message: /ProvidedmoduleisnotaninstanceofModule/
 +};
 constgetters=['identifier','context','namespace','status','error'];
 getters.forEach((getter)=>{
 assert.throws(()=>{
 // eslint-disable-next-line no-unused-expressions
 Module.prototype[getter];
 -},{
 -code: 'ERR_VM_MODULE_NOT_MODULE',
 -message: /ProvidedmoduleisnotaninstanceofModule/
 -});
 +},expectedError);
 +assert.throws(()=>{
 +// eslint-disable-next-line no-unused-expressions
 +SourceTextModule.prototype[getter];
 +},expectedError);
 });
 +// `dependencySpecifiers` getter is just part of SourceTextModule
 +assert.throws(()=>{
 +// eslint-disable-next-line no-unused-expressions
 +SourceTextModule.prototype.dependencySpecifiers;
 +},expectedError);
+}
 constfinished=common.mustCall();