test: refactoring test with common.mustCall

PR-URL: #12702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Author: weewey

test/parallel/test-https-simple.js

@@ -34,28 +34,31 @@ const serverCallback = common.mustCall(function(req, res) {
 
 constserver=https.createServer(options,serverCallback);
 
-server.listen(0,function(){
+server.listen(0,common.mustCall(()=>{
 // Do a request ignoring the unauthorized server certs
+constport=server.address().port;
+
 constnoCertCheckOptions={
 hostname: '127.0.0.1',
-port: this.address().port,
+port: port,
 path: '/',
 method: 'GET',
 rejectUnauthorized: false
 };
+
 noCertCheckOptions.Agent=newhttps.Agent(noCertCheckOptions);
 
-constreq=https.request(noCertCheckOptions,function(res){
+constreq=https.request(noCertCheckOptions,common.mustCall((res)=>{
 letresponseBody='';
 res.on('data',function(d){
 responseBody=responseBody+d;
 });
 
-res.on('end',function(){
+res.on('end',common.mustCall(()=>{
 assert.strictEqual(responseBody,body);
 testSucceeded();
-});
-});
+}));
+}));
 req.end();
 
 req.on('error',function(e){
@@ -65,7 +68,7 @@ server.listen(0, function() {
 // Do a request that throws error due to the invalid server certs
 constcheckCertOptions={
 hostname: '127.0.0.1',
-port: this.address().port,
+port: port,
 path: '/',
 method: 'GET'
 };
@@ -81,11 +84,11 @@ server.listen(0, function() {
 });
 checkCertReq.end();
 
-checkCertReq.on('error',function(e){
+checkCertReq.on('error',common.mustCall((e)=>{
 assert.strictEqual(e.code,'UNABLE_TO_VERIFY_LEAF_SIGNATURE');
 testSucceeded();
-});
-});
+}));
+}));
 
 process.on('exit',function(){
 assert.strictEqual(successful,tests);