stream: port more test262 tests

Add some test262 tests for `every`, add some `length` checks.
Turns out properties need to be writable after all according to the
test262 tests.
PR-URL: #41974
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: benjamingr

lib/internal/streams/operators.js

@@ -186,15 +186,15 @@ function asIndexedPairs(options = undefined) {
 }.call(this);
 }
 
-asyncfunctionsome(fn,options){
+asyncfunctionsome(fn,options=undefined){
 // eslint-disable-next-line no-unused-vars
 forawait(constunusedoffilter.call(this,fn,options)){
 returntrue;
 }
 returnfalse;
 }
 
-asyncfunctionevery(fn,options){
+asyncfunctionevery(fn,options=undefined){
 if(typeoffn!=='function'){
 thrownewERR_INVALID_ARG_TYPE(
 'fn',['Function','AsyncFunction'],fn);

lib/stream.js

@@ -75,6 +75,9 @@ for (const key of ObjectKeys(streamReturningOperators)) {
 for(constkeyofObjectKeys(promiseReturningOperators)){
 constop=promiseReturningOperators[key];
 functionfn(...args){
+if(new.target){
+throwERR_ILLEGAL_CONSTRUCTOR();
+}
 returnReflectApply(op,this,args);
 }
 ObjectDefineProperty(fn,'name',{value: op.name});
@@ -83,7 +86,7 @@ for (const key of ObjectKeys(promiseReturningOperators)) {
 value: fn,
 enumerable: false,
 configurable: true,
-writable: false,
+writable: true,
 });
 }
 Stream.Writable=require('internal/streams/writable');

test/parallel/test-stream-iterator-helpers-test262-tests.mjs

@@ -1,4 +1,4 @@
-import'../common/index.mjs';
+import{mustCall}from'../common/index.mjs';
 import{Readable}from'stream';
 importassertfrom'assert';
 
@@ -68,7 +68,7 @@ import assert from 'assert';
 );
 assert.strictEqual(descriptor.enumerable,false);
 assert.strictEqual(descriptor.configurable,true);
-// assert.strictEqual(descriptor.writable, false);
+// assert.strictEqual(descriptor.writable, true);
 }
 {
 // drop/length
@@ -79,7 +79,7 @@ import assert from 'assert';
 );
 assert.strictEqual(descriptor.enumerable,false);
 assert.strictEqual(descriptor.configurable,true);
-// assert.strictEqual(descriptor.writable, false);
+// assert.strictEqual(descriptor.writable, true);
 // drop/limit-equals-total
 constiterator=Readable.from([1,2]).drop(2);
 constresult=awaititerator[Symbol.asyncIterator]().next();
@@ -111,5 +111,58 @@ import assert from 'assert';
 // drop/proto
 constproto=Object.getPrototypeOf(Readable.prototype.drop);
 assert.strictEqual(proto,Function.prototype);
+}
+{
+// every/abrupt-iterator-close
+conststream=Readable.from([1,2,3]);
+conste=newError();
+awaitassert.rejects(stream.every(mustCall(()=>{
+throwe;
+},1)),e);
+}
+{
+// every/callable-fn
+awaitassert.rejects(Readable.from([1,2]).every({}),TypeError);
+}
+{
+// every/callable
+Readable.prototype.every.call(Readable.from([]),()=>{});
+// eslint-disable-next-line array-callback-return
+Readable.from([]).every(()=>{});
+assert.throws(()=>{
+constr=Readable.from([]);
+newr.every(()=>{});
+},TypeError);
+}
 
+{
+// every/false
+constiterator=Readable.from([1,2,3]);
+constresult=awaititerator.every((v)=>v===1);
+assert.strictEqual(result,false);
+}
+{
+// every/every
+constiterator=Readable.from([1,2,3]);
+constresult=awaititerator.every((v)=>true);
+assert.strictEqual(result,true);
+}
+
+{
+// every/is-function
+assert.strictEqual(typeofReadable.prototype.every,'function');
+}
+{
+// every/length
+assert.strictEqual(Readable.prototype.every.length,1);
+// every/name
+assert.strictEqual(Readable.prototype.every.name,'every');
+// every/propdesc
+constdescriptor=Object.getOwnPropertyDescriptor(
+Readable.prototype,
+'every'
+);
+assert.strictEqual(descriptor.enumerable,false);
+assert.strictEqual(descriptor.configurable,true);
+assert.strictEqual(descriptor.writable,true);
 }