buffer: allow invalid encoding in from

ronag · targos · commit 84bf93b7eaac · 2024-10-02T07:57:42.000+02:00
Looks like a bug to me but the change should probably done in a semver majpr. PR-URL: #54533 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -474,7 +474,7 @@ function createFromString(string, ops, length = ops.byteLength(string)) {
 
 function fromString(string, encoding) {
 let ops;
- if (!encoding || encoding === 'utf8') {
+ if (!encoding || encoding === 'utf8' || typeof encoding !== 'string') {
 ops = encodingOps.utf8;
 } else {
 ops = getEncodingOps(encoding);
diff --git a/test/parallel/test-buffer-from.js b/test/parallel/test-buffer-from.js
@@ -139,3 +139,6 @@ throws(() => {
 code: 'ERR_OUT_OF_RANGE',
 })
 );
+
+// Invalid encoding is allowed
+Buffer.from('asd', 1);

-Original file line number
+Diff line change
 functionfromString(string,encoding){
 letops;
 -if(!encoding||encoding==='utf8'){
 +if(!encoding||encoding==='utf8'||typeofencoding!=='string'){
 ops=encodingOps.utf8;
 }else{
 ops=getEncodingOps(encoding);