readline: remove max limit of crlfDelay

Backport-PR-URL: #14899
PR-URL: #13497
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

Author: Azard

doc/api/readline.md

@@ -362,7 +362,9 @@ added: v0.1.98
 *`crlfDelay` {number} If the delay between `\r` and `\n` exceeds
 `crlfDelay` milliseconds, both `\r` and `\n` will be treated as separate
  end-of-line input. Default to `100` milliseconds.
-`crlfDelay` will be coerced to `[100, 2000]` range.
+`crlfDelay` will be coerced to a number no less than `100`. It can be set to
+`Infinity`, in which case `\r` followed by `\n` will always be considered a
+ single newline.
 *`removeHistoryDuplicates` {boolean} If `true`, when a new input line added
  to the history list duplicates an older one, this removes the older line
  from the list. Defaults to `false`.

lib/readline.js

@@ -8,7 +8,6 @@
 
 constkHistorySize=30;
 constkMincrlfDelay=100;
-constkMaxcrlfDelay=2000;
 
 constutil=require('util');
 constdebug=util.debuglog('readline');
@@ -83,8 +82,8 @@ function Interface(input, output, completer, terminal) {
 this.input=input;
 this.historySize=historySize;
 this.removeHistoryDuplicates=!!removeHistoryDuplicates;
-this.crlfDelay=Math.max(kMincrlfDelay,
-Math.min(kMaxcrlfDelay,crlfDelay>>>0));
+this.crlfDelay=crlfDelay ?
+Math.max(kMincrlfDelay,crlfDelay) : kMincrlfDelay;
 
 // Check arity, 2 - for async, 1 for sync
 if(typeofcompleter==='function'){

test/parallel/test-readline-interface.js

@@ -40,14 +40,25 @@ function isWarned(emitter) {
 }
 
 {
-// Maximum crlfDelay is 2000ms
+// set crlfDelay to float 100.5ms
 constfi=newFakeInput();
 constrli=newreadline.Interface({
 input: fi,
 output: fi,
-crlfDelay: 1<<30
+crlfDelay: 100.5
 });
-assert.strictEqual(rli.crlfDelay,2000);
+assert.strictEqual(rli.crlfDelay,100.5);
+rli.close();
+}
+
+{
+constfi=newFakeInput();
+constrli=newreadline.Interface({
+input: fi,
+output: fi,
+crlfDelay: 5000
+});
+assert.strictEqual(rli.crlfDelay,5000);
 rli.close();
 }
 
@@ -225,7 +236,7 @@ function isWarned(emitter) {
 rli.close();
 
 // Emit two line events when the delay
-// between \r and \n exceeds crlfDelay
+// between \r and \n exceeds crlfDelay
 {
 constfi=newFakeInput();
 constdelay=200;
@@ -247,8 +258,55 @@ function isWarned(emitter) {
 }),delay*2);
 }
 
+// Emit one line events when the delay between \r and \n is
+// over the default crlfDelay but within the setting value
+{
+constfi=newFakeInput();
+constdelay=200;
+constcrlfDelay=500;
+constrli=newreadline.Interface({
+input: fi,
+output: fi,
+terminal: terminal,
+ crlfDelay
+});
+letcallCount=0;
+rli.on('line',function(line){
+callCount++;
+});
+fi.emit('data','\r');
+setTimeout(common.mustCall(()=>{
+fi.emit('data','\n');
+assert.strictEqual(callCount,1);
+rli.close();
+}),delay);
+}
+
+// set crlfDelay to `Infinity` is allowed
+{
+constfi=newFakeInput();
+constdelay=200;
+constcrlfDelay=Infinity;
+constrli=newreadline.Interface({
+input: fi,
+output: fi,
+terminal: terminal,
+ crlfDelay
+});
+letcallCount=0;
+rli.on('line',function(line){
+callCount++;
+});
+fi.emit('data','\r');
+setTimeout(common.mustCall(()=>{
+fi.emit('data','\n');
+assert.strictEqual(callCount,1);
+rli.close();
+}),delay);
+}
+
 // \t when there is no completer function should behave like an ordinary
-// character
+// character
 fi=newFakeInput();
 rli=newreadline.Interface({input: fi,output: fi,terminal: true});
 called=false;
@@ -494,7 +552,7 @@ function isWarned(emitter) {
 assert.strictEqual(isWarned(process.stdout._events),false);
 }
 
-//can create a new readline Interface with a null output arugument
+//can create a new readline Interface with a null output arugument
 fi=newFakeInput();
 rli=newreadline.Interface({input: fi,output: null,terminal: terminal});