test: make test-node-output-v8-warning more flexible

codebytere · aduh95 · commit 8634e054d4cd · 2024-10-23T22:54:21.000+02:00
PR-URL: #55401 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
diff --git a/test/parallel/test-node-output-v8-warning.mjs b/test/parallel/test-node-output-v8-warning.mjs
@@ -2,23 +2,28 @@ import '../common/index.mjs';
 import * as fixtures from '../common/fixtures.mjs';
 import * as snapshot from '../common/assertSnapshot.js';
 import { describe, it } from 'node:test';
+import { basename } from 'node:path';
 
 function replaceNodeVersion(str) {
 return str.replaceAll(process.version, '*');
 }
 
+function replaceExecName(str) {
+ const baseName = basename(process.argv0 || 'node', '.exe');
+ return str.replaceAll(`${baseName} --`, '* --');
+}
+
 describe('v8 output', { concurrency: !process.env.TEST_PARALLEL }, () => {
 function normalize(str) {
 return str.replaceAll(snapshot.replaceWindowsPaths(process.cwd()), '')
 .replaceAll(/:\d+/g, ':*')
 .replaceAll('/', '*')
 .replaceAll('*test*', '*')
 .replaceAll(/.*?\*fixtures\*v8\*/g, '(node:*) V8: *') // Replace entire path before fixtures/v8
- .replaceAll('*fixtures*v8*', '*')
- .replaceAll('node --', '* --');
+ .replaceAll('*fixtures*v8*', '*');
 }
 const common = snapshot
- .transform(snapshot.replaceWindowsLineEndings, snapshot.replaceWindowsPaths, replaceNodeVersion);
+ .transform(snapshot.replaceWindowsLineEndings, snapshot.replaceWindowsPaths, replaceNodeVersion, replaceExecName);
 const defaultTransform = snapshot.transform(common, normalize);
 const tests = [
 { name: 'v8/v8_warning.js' },

-Original file line number
+Diff line change
 import*asfixturesfrom'../common/fixtures.mjs';
 import*assnapshotfrom'../common/assertSnapshot.js';
 import{describe,it}from'node:test';
 +import{basename}from'node:path';
 functionreplaceNodeVersion(str){
 returnstr.replaceAll(process.version,'*');
+}
 +functionreplaceExecName(str){
 +constbaseName=basename(process.argv0||'node','.exe');
 +returnstr.replaceAll(`${baseName} --`,'* --');
 +}
++
 describe('v8 output',{concurrency: !process.env.TEST_PARALLEL},()=>{
 functionnormalize(str){
 returnstr.replaceAll(snapshot.replaceWindowsPaths(process.cwd()),'')
 .replaceAll(/:\d+/g,':*')
 .replaceAll('/','*')
 .replaceAll('*test*','*')
 .replaceAll(/.*?\*fixtures\*v8\*/g,'(node:*) V8: *')// Replace entire path before fixtures/v8
 -.replaceAll('*fixtures*v8*','*')
 -.replaceAll('node --','* --');
 +.replaceAll('*fixtures*v8*','*');
+}
 constcommon=snapshot
 -.transform(snapshot.replaceWindowsLineEndings,snapshot.replaceWindowsPaths,replaceNodeVersion);
 +.transform(snapshot.replaceWindowsLineEndings,snapshot.replaceWindowsPaths,replaceNodeVersion,replaceExecName);
 constdefaultTransform=snapshot.transform(common,normalize);
 consttests=[
 {name: 'v8/v8_warning.js'},