Skip to content

Commit 86c27c6

Browse files
ImHypetargos
authored andcommitted
test: add mustcall in test-net-bytes-read.js
* add mustcall() on createServerListener * add mustcall() on listenPortListener * add mustCall() on onConnectListener * add mustCallAtLeast() on onDataListener PR-URL: #27471 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 7be1e0a commit 86c27c6

1 file changed

Lines changed: 24 additions & 15 deletions

File tree

‎test/parallel/test-net-bytes-read.js‎

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,33 +6,42 @@ const net = require('net');
66

77
constbig=Buffer.alloc(1024*1024);
88

9-
constserver=net.createServer((socket)=>{
9+
consthandler=common.mustCall((socket)=>{
1010
socket.end(big);
1111
server.close();
12-
}).listen(0,()=>{
12+
});
13+
14+
constonListen=common.mustCall(()=>{
1315
letprev=0;
1416

1517
functioncheckRaise(value){
1618
assert(value>prev);
1719
prev=value;
1820
}
1921

20-
constsocket=net.connect(server.address().port,()=>{
21-
socket.on('data',(chunk)=>{
22-
checkRaise(socket.bytesRead);
23-
});
22+
constonData=common.mustCallAtLeast((chunk)=>{
23+
checkRaise(socket.bytesRead);
24+
});
2425

25-
socket.on('end',common.mustCall(()=>{
26-
assert.strictEqual(socket.bytesRead,prev);
27-
assert.strictEqual(big.length,prev);
28-
}));
26+
constonEnd=common.mustCall(()=>{
27+
assert.strictEqual(socket.bytesRead,prev);
28+
assert.strictEqual(big.length,prev);
29+
});
2930

30-
socket.on('close',common.mustCall(()=>{
31-
assert(!socket._handle);
32-
assert.strictEqual(socket.bytesRead,prev);
33-
assert.strictEqual(big.length,prev);
34-
}));
31+
constonClose=common.mustCall(()=>{
32+
assert(!socket._handle);
33+
assert.strictEqual(socket.bytesRead,prev);
34+
assert.strictEqual(big.length,prev);
35+
});
3536

37+
constonConnect=common.mustCall(()=>{
38+
socket.on('data',onData);
39+
socket.on('end',onEnd);
40+
socket.on('close',onClose);
3641
socket.end();
3742
});
43+
44+
constsocket=net.connect(server.address().port,onConnect);
3845
});
46+
47+
constserver=net.createServer(handler).listen(0,onListen);

0 commit comments

Comments
 (0)