http2: destroy the socket properly and add tests

Fix a bug where the socket wasn't being correctly destroyed and
adjust existing tests, as well as add additional tests.
PR-URL: #19852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>

Author: 2 people

lib/internal/http2/core.js

@@ -1150,7 +1150,7 @@ class Http2Session extends EventEmitter {
 // Otherwise, destroy immediately.
 if(!socket.destroyed){
 if(!error){
-setImmediate(socket.end.bind(socket));
+setImmediate(socket.destroy.bind(socket));
 }else{
 socket.destroy(error);
 }

test/parallel/test-http2-many-writes-and-destroy.js

@@ -0,0 +1,30 @@
+'use strict';
+
+constcommon=require('../common');
+if(!common.hasCrypto)
+common.skip('missing crypto');
+consthttp2=require('http2');
+
+{
+constserver=http2.createServer((req,res)=>{
+req.pipe(res);
+});
+
+server.listen(0,()=>{
+consturl=`http://localhost:${server.address().port}`;
+constclient=http2.connect(url);
+constreq=client.request({':method': 'POST'});
+
+for(leti=0;i<4000;i++){
+req.write(Buffer.alloc(6));
+}
+
+req.on('close',common.mustCall(()=>{
+console.log('(req onclose)');
+server.close();
+client.close();
+}));
+
+req.once('data',common.mustCall(()=>req.destroy()));
+});
+}

test/parallel/test-http2-pipe.js

@@ -33,6 +33,7 @@ server.listen(0, common.mustCall(() => {
 constclient=http2.connect(`http://localhost:${server.address().port}`);
 
 constreq=client.request({':method': 'POST'});
+
 req.on('response',common.mustCall());
 req.resume();
 

test/parallel/test-http2-server-close-callback.js

@@ -0,0 +1,24 @@
+'use strict';
+
+constcommon=require('../common');
+if(!common.hasCrypto)
+common.skip('missing crypto');
+
+consthttp2=require('http2');
+
+constserver=http2.createServer();
+
+server.listen(0,common.mustCall(()=>{
+constclient=http2.connect(`http://localhost:${server.address().port}`);
+client.on('error',(err)=>{
+if(err.code!=='ECONNRESET')
+throwerr;
+});
+}));
+
+server.on('session',common.mustCall((s)=>{
+setImmediate(()=>{
+server.close(common.mustCall());
+s.destroy();
+});
+}));

test/parallel/test-http2-server-stream-session-destroy.js

@@ -39,10 +39,16 @@ server.on('stream', common.mustCall((stream) => {
 
 server.listen(0,common.mustCall(()=>{
 constclient=h2.connect(`http://localhost:${server.address().port}`);
-client.on('error',()=>{});
+client.on('error',(err)=>{
+if(err.code!=='ECONNRESET')
+throwerr;
+});
 constreq=client.request();
 req.resume();
 req.on('end',common.mustCall());
-req.on('close',common.mustCall(()=>server.close()));
-req.on('error',()=>{});
+req.on('close',common.mustCall(()=>server.close(common.mustCall())));
+req.on('error',(err)=>{
+if(err.code!=='ECONNRESET')
+throwerr;
+});
 }));

test/parallel/test-http2-session-unref.js

@@ -34,17 +34,23 @@ server.listen(0, common.mustCall(() => {
 // unref destroyed client
 {
 constclient=http2.connect(`http://localhost:${port}`);
-client.destroy();
-client.unref();
+
+client.on('connect',common.mustCall(()=>{
+client.destroy();
+client.unref();
+}));
 }
 
 // unref destroyed client
 {
 constclient=http2.connect(`http://localhost:${port}`,{
 createConnection: common.mustCall(()=>clientSide)
 });
-client.destroy();
-client.unref();
+
+client.on('connect',common.mustCall(()=>{
+client.destroy();
+client.unref();
+}));
 }
 }));
 server.emit('connection',serverSide);

test/sequential/test-http2-max-session-memory.js

@@ -13,6 +13,10 @@ const largeBuffer = Buffer.alloc(1e6);
 constserver=http2.createServer({maxSessionMemory: 1});
 
 server.on('stream',common.mustCall((stream)=>{
+stream.on('error',(err)=>{
+if(err.code!=='ECONNRESET')
+throwerr;
+});
 stream.respond();
 stream.end(largeBuffer);
 }));