test: isolate unusual assert test in its own file

test-assert.js contains a test that writes to the source tree, requires
an internal module, and depends on modules not needed by the plethora of
other test cases in the file. Move it to its own file so that there are
not side effects in test-assert.js and so that it can be refactored to
not write to the source tree.
PR-URL: #20861
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Author: Trott

test/parallel/test-assert-builtins-not-read-from-filesystem.js

@@ -0,0 +1,44 @@
+// Flags: --expose-internals
+
+'use strict';
+
+require('../common');
+
+constassert=require('assert');
+constEventEmitter=require('events');
+const{ errorCache }=require('internal/assert');
+const{ writeFileSync, unlinkSync }=require('fs');
+
+// Do not read filesystem for error messages in builtin modules.
+{
+conste=newEventEmitter();
+
+e.on('hello',assert);
+
+letthrew=false;
+try{
+e.emit('hello',false);
+}catch(err){
+constframes=err.stack.split('\n');
+const[,filename,line,column]=frames[1].match(/\((.+):(\d+):(\d+)\)/);
+// Reset the cache to check again
+constsize=errorCache.size;
+errorCache.delete(`${filename}${line-1}${column-1}`);
+assert.strictEqual(errorCache.size,size-1);
+constdata=`${'\n'.repeat(line-1)}${' '.repeat(column-1)}`+
+'ok(failed(badly));';
+try{
+writeFileSync(filename,data);
+assert.throws(
+()=>e.emit('hello',false),
+{
+message: 'false == true'
+}
+);
+threw=true;
+}finally{
+unlinkSync(filename);
+}
+}
+assert(threw);
+}

test/parallel/test-assert.js

@@ -19,17 +19,12 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-// Flags: --expose-internals
-
 'use strict';
 
 /* eslint-disable node-core/prefer-common-expectserror */
 
 constcommon=require('../common');
 constassert=require('assert');
-constEventEmitter=require('events');
-const{ errorCache }=require('internal/assert');
-const{ writeFileSync, unlinkSync }=require('fs');
 const{ inspect }=require('util');
 consta=assert;
 
@@ -793,40 +788,6 @@ common.expectsError(
 }
 );
 
-// Do not try to check Node.js modules.
-{
-conste=newEventEmitter();
-
-e.on('hello',assert);
-
-letthrew=false;
-try{
-e.emit('hello',false);
-}catch(err){
-constframes=err.stack.split('\n');
-const[,filename,line,column]=frames[1].match(/\((.+):(\d+):(\d+)\)/);
-// Reset the cache to check again
-constsize=errorCache.size;
-errorCache.delete(`${filename}${line-1}${column-1}`);
-assert.strictEqual(errorCache.size,size-1);
-constdata=`${'\n'.repeat(line-1)}${' '.repeat(column-1)}`+
-'ok(failed(badly));';
-try{
-writeFileSync(filename,data);
-assert.throws(
-()=>e.emit('hello',false),
-{
-message: 'false == true'
-}
-);
-threw=true;
-}finally{
-unlinkSync(filename);
-}
-}
-assert(threw);
-}
-
 common.expectsError(
 // eslint-disable-next-line no-restricted-syntax
 ()=>assert.throws(()=>{},'Error message','message'),