test: add onerror test cases to policy

watilde · targos · commit 8958af4aa009 · 2020-11-03T17:54:16.000+01:00
Increase test coverage of lib/internal/policy/manifest.js PR-URL: #35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-policy-parse-integrity.js b/test/parallel/test-policy-parse-integrity.js
@@ -44,7 +44,8 @@ const packageFilepath = path.join(tmpdirPath, 'package.json');
 const packageURL = pathToFileURL(packageFilepath);
 const packageBody = '{"main": "dep.js"}';
 
-function test({ shouldFail, integrity }) {
+function test({ shouldFail, integrity, manifest = {} }) {
+ manifest.resources = {};
 const resources = {
 [packageURL]: {
 body: packageBody,
@@ -55,9 +56,6 @@ function test({ shouldFail, integrity }) {
 integrity
 }
 };
- const manifest = {
- resources: {},
- };
 for (const [url, { body, integrity }] of Object.entries(resources)) {
 manifest.resources[url] = {
 integrity,
@@ -96,3 +94,17 @@ test({
 depBody
 )}`,
 });
+test({
+ shouldFail: true,
+ integrity: `sha256-${hash('sha256', 'file:///')}`,
+ manifest: {
+ onerror: 'exit'
+ }
+});
+test({
+ shouldFail: false,
+ integrity: `sha256-${hash('sha256', 'file:///')}`,
+ manifest: {
+ onerror: 'log'
+ }
+});
diff --git a/test/parallel/test-policy-scopes-integrity.js b/test/parallel/test-policy-scopes-integrity.js
@@ -280,3 +280,36 @@ const assert = require('assert');
 }
 }
 // #endregion
+// #startonerror
+{
+ const manifest = new Manifest({
+ scopes: {
+ 'file:///': {
+ integrity: true
+ }
+ },
+ onerror: 'throw'
+ });
+ assert.throws(
+ () => {
+ manifest.assertIntegrity('http://example.com');
+ },
+ /ERR_MANIFEST_ASSERT_INTEGRITY/
+ );
+}
+{
+ assert.throws(
+ () => {
+ new Manifest({
+ scopes: {
+ 'file:///': {
+ integrity: true
+ }
+ },
+ onerror: 'unknown'
+ });
+ },
+ /ERR_MANIFEST_UNKNOWN_ONERROR/
+ );
+}
+// #endonerror

-Original file line number
+Diff line change
 constpackageURL=pathToFileURL(packageFilepath);
 constpackageBody='{"main": "dep.js"}';
 -functiontest({ shouldFail, integrity }){
 +functiontest({ shouldFail, integrity, manifest ={}}){
 +manifest.resources={};
 constresources={
 [packageURL]: {
 body: packageBody,
  integrity
+}
 };
 -constmanifest={
 -resources: {},
 -};
 for(const[url,{ body, integrity }]ofObject.entries(resources)){
 manifest.resources[url]={
  integrity,
 depBody
 )}`,
 });
 +test({
 +shouldFail: true,
 +integrity: `sha256-${hash('sha256','file:///')}`,
 +manifest: {
 +onerror: 'exit'
 +}
 +});
 +test({
 +shouldFail: false,
 +integrity: `sha256-${hash('sha256','file:///')}`,
 +manifest: {
 +onerror: 'log'
 +}
 +});