domain: do not import util for a simple type check

BridgeAR · targos · commit 8a333a451971 · 2019-11-10T14:50:08.000+01:00
This removes `require('util')` from the `domain` module. There was only a single simple type check used from the `util` module which is now inlined instead. PR-URL: #29825 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
diff --git a/lib/domain.js b/lib/domain.js
@@ -28,7 +28,6 @@
 
 const { Object, Reflect } = primordials;
 
-const util = require('util');
 const EventEmitter = require('events');
 const {
 ERR_DOMAIN_CALLBACK_NOT_AVAILABLE,
@@ -207,7 +206,7 @@ Domain.prototype.members = undefined;
 Domain.prototype._errorHandler = function(er) {
 var caught = false;
 
- if (!util.isPrimitive(er)) {
+ if ((typeof er === 'object' && er !== null) || typeof er === 'function') {
 Object.defineProperty(er, 'domain', {
 configurable: true,
 enumerable: false,

-Original file line number
+Diff line change
 const{ Object, Reflect }=primordials;
 -constutil=require('util');
 constEventEmitter=require('events');
 const{
 ERR_DOMAIN_CALLBACK_NOT_AVAILABLE,
 Domain.prototype._errorHandler=function(er){
 varcaught=false;
 -if(!util.isPrimitive(er)){
 +if((typeofer==='object'&&er!==null)||typeofer==='function'){
 Object.defineProperty(er,'domain',{
 configurable: true,
 enumerable: false,