test: improve coverage of lib/_http_client.js

PR-URL: #38599
Refs: https://coverage.nodejs.org/coverage-f37c26b8a2e10d0a/lib/_http_client.js.html#L200
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Author: pd4d10

test/parallel/test-http-createConnection.js

@@ -25,32 +25,36 @@ const http = require('http');
 constnet=require('net');
 constassert=require('assert');
 
+functioncommonHttpGet(fn){
+if(typeoffn==='function'){
+fn=common.mustCall(fn);
+}
+returnnewPromise((resolve,reject)=>{
+http.get({createConnection: fn},(res)=>{
+resolve(res);
+}).on('error',(err)=>{
+reject(err);
+});
+});
+}
+
 constserver=http.createServer(common.mustCall(function(req,res){
 res.end();
-},4)).listen(0,'127.0.0.1',function(){
-letfn=common.mustCall(createConnection);
-http.get({createConnection: fn},function(res){
-res.resume();
-fn=common.mustCall(createConnectionAsync);
-http.get({createConnection: fn},function(res){
-res.resume();
-fn=common.mustCall(createConnectionBoth1);
-http.get({createConnection: fn},function(res){
-res.resume();
-fn=common.mustCall(createConnectionBoth2);
-http.get({createConnection: fn},function(res){
-res.resume();
-fn=common.mustCall(createConnectionError);
-http.get({createConnection: fn},function(res){
-assert.fail('Unexpected response callback');
-}).on('error',common.mustCall(function(err){
-assert.strictEqual(err.message,'Could not create socket');
-server.close();
-}));
-});
-});
-});
+},4)).listen(0,'127.0.0.1',async()=>{
+awaitcommonHttpGet(createConnection);
+awaitcommonHttpGet(createConnectionAsync);
+awaitcommonHttpGet(createConnectionBoth1);
+awaitcommonHttpGet(createConnectionBoth2);
+
+// Errors
+awaitassert.rejects(()=>commonHttpGet(createConnectionError),{
+message: 'sync'
+});
+awaitassert.rejects(()=>commonHttpGet(createConnectionAsyncError),{
+message: 'async'
 });
+
+server.close();
 });
 
 functioncreateConnection(){
@@ -78,5 +82,9 @@ function createConnectionBoth2(options, cb) {
 }
 
 functioncreateConnectionError(options,cb){
-process.nextTick(cb,newError('Could not create socket'));
+thrownewError('sync');
+}
+
+functioncreateConnectionAsyncError(options,cb){
+process.nextTick(cb,newError('async'));
 }

test/parallel/test-http-insecure-parser-per-stream.js

@@ -80,3 +80,15 @@ const MakeDuplexPair = require('../common/duplexpair');
 'Hello: foo\x08foo\r\n'+
 '\r\n\r\n');
 }
+
+// Test 5: Invalid argument type
+{
+assert.throws(
+()=>http.request({insecureHTTPParser: 0},common.mustNotCall()),
+common.expectsError({
+code: 'ERR_INVALID_ARG_TYPE',
+message: 'The "options.insecureHTTPParser" property must be of'+
+' type boolean. Received type number (0)'
+})
+);
+}