Revert "inspector: move process.binding to internalBinding"

This reverts commit c168672.
PR-URL: #25446
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Author: joyeecheung

lib/inspector.js

@@ -11,7 +11,7 @@ const {
 }=require('internal/errors').codes;
 const{ validateString }=require('internal/validators');
 constutil=require('util');
-const{ Connection, open, url }=internalBinding('inspector');
+const{ Connection, open, url }=process.binding('inspector');
 
 if(!Connection)
 thrownewERR_INSPECTOR_NOT_AVAILABLE();

lib/internal/bootstrap/loaders.js

@@ -85,7 +85,6 @@
 'fs_event_wrap',
 'http_parser',
 'icu',
-'inspector',
 'js_stream',
 'natives',
 'os',

lib/internal/inspector_async_hook.js

@@ -1,6 +1,6 @@
 'use strict';
 
-constinspector=internalBinding('inspector');
+constinspector=process.binding('inspector');
 
 if(!inspector||!inspector.asyncTaskScheduled){
 exports.setup=function(){};

lib/internal/modules/cjs/helpers.js

@@ -108,7 +108,7 @@ if (getOptionValue('--experimental-worker')) {
 builtinLibs.sort();
 }
 
-if(typeofinternalBinding('inspector').open==='function'){
+if(typeofprocess.binding('inspector').open==='function'){
 builtinLibs.push('inspector');
 builtinLibs.sort();
 }

lib/internal/modules/cjs/loader.js

@@ -706,7 +706,7 @@ Module.prototype._compile = function(content, filename) {
 // Set breakpoint on module start
 if(filename===resolvedArgv){
 deleteprocess._breakFirstLine;
-inspectorWrapper=internalBinding('inspector').callAndPauseOnStart;
+inspectorWrapper=process.binding('inspector').callAndPauseOnStart;
 }
 }
 vardirname=path.dirname(filename);

lib/internal/modules/esm/module_job.js

@@ -73,7 +73,7 @@ class ModuleJob {
 try{
 if(this.isMain&&process._breakFirstLine){
 deleteprocess._breakFirstLine;
-constinitWrapper=internalBinding('inspector').callAndPauseOnStart;
+constinitWrapper=process.binding('inspector').callAndPauseOnStart;
 initWrapper(this.module.instantiate,this.module);
 }else{
 this.module.instantiate();

lib/internal/process/coverage.js

@@ -51,7 +51,7 @@ function disableAllAsyncHooks() {
 exports.writeCoverage=writeCoverage;
 
 functionsetup(){
-const{ Connection }=internalBinding('inspector');
+const{ Connection }=process.binding('inspector');
 if(!Connection){
 console.warn('inspector not enabled');
 return;

src/inspector_js_api.cc

@@ -315,5 +315,5 @@ void Initialize(Local<Object> target, Local<Value> unused,
 } // namespace inspector
 } // namespace node
 
-NODE_MODULE_CONTEXT_AWARE_INTERNAL(inspector,
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector,
  node::inspector::Initialize);

src/node.cc

@@ -2238,5 +2238,5 @@ int Start(int argc, char** argv) {
 #if !HAVE_INSPECTOR
 voidInitialize() {}
 
-NODE_MODULE_CONTEXT_AWARE_INTERNAL(inspector, Initialize)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, Initialize)
 #endif// !HAVE_INSPECTOR

test/parallel/test-process-binding-internalbinding-whitelist.js

@@ -16,5 +16,4 @@ assert(process.binding('url'));
 assert(process.binding('spawn_sync'));
 assert(process.binding('js_stream'));
 assert(process.binding('buffer'));
-assert(process.binding('inspector'));
 assert(process.binding('os'));