deps: patch V8 to 6.6.346.32

PR-URL: #20748
Refs: v8/v8@6.6.346.31...6.6.346.32
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

Author: MylesBorins

deps/v8/include/v8-version.h

@@ -11,7 +11,7 @@
 #defineV8_MAJOR_VERSION 6
 #defineV8_MINOR_VERSION 6
 #defineV8_BUILD_NUMBER 346
-#defineV8_PATCH_LEVEL31
+#defineV8_PATCH_LEVEL32
 
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/managed.h

@@ -59,22 +59,30 @@ class Managed : public Foreign {
  isolate->factory()->NewForeign(reinterpret_cast<Address>(finalizer)));
  Handle<Object> global_handle = isolate->global_handles()->Create(*handle);
  finalizer->global_handle_location = global_handle.location();
-GlobalHandles::MakeWeak(finalizer->global_handle_location,
-handle->GetFinalizer(), &Managed<CppType>::GCDelete,
- v8::WeakCallbackType::kParameter);
+GlobalHandles::MakeWeak(
+finalizer->global_handle_location, handle->GetFinalizer(),
+&ResetWeakAndScheduleGCDelete, v8::WeakCallbackType::kParameter);
 
 return handle;
  }
 
 private:
-staticvoidGCDelete(const v8::WeakCallbackInfo<void>& data) {
+staticvoidResetWeakAndScheduleGCDelete(
+const v8::WeakCallbackInfo<void>& data) {
  FinalizerWithHandle* finalizer =
 reinterpret_cast<FinalizerWithHandle*>(data.GetParameter());
-
+GlobalHandles::Destroy(finalizer->global_handle_location);
  Isolate* isolate = reinterpret_cast<Isolate*>(data.GetIsolate());
  isolate->UnregisterFromReleaseAtTeardown(finalizer);
+// We need to call GCDelete as a second pass callback because
+// it can trigger garbage collection. The first pass callbacks
+// are not allowed to invoke V8 API.
+ data.SetSecondPassCallback(&GCDelete);
+ }
 
-GlobalHandles::Destroy(finalizer->global_handle_location);
+staticvoidGCDelete(const v8::WeakCallbackInfo<void>& data) {
+ FinalizerWithHandle* finalizer =
+reinterpret_cast<FinalizerWithHandle*>(data.GetParameter());
 NativeDelete(finalizer);
  }