timers: optimize timer functions with improved argument handling

PR-URL: #57072
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: gurgunday

lib/timers.js

@@ -22,7 +22,6 @@
 'use strict';
 
 const{
- ArrayPrototypePush,
  MathTrunc,
  ObjectDefineProperties,
  ObjectDefineProperty,
@@ -131,38 +130,13 @@ function enroll(item, msecs) {
  * after `after` milliseconds.
  * @param {Function} callback
  * @param {number} [after]
- * @param {any} [arg1]
- * @param {any} [arg2]
- * @param {any} [arg3]
+ * @param {...any} [args]
  * @returns {Timeout}
  */
-functionsetTimeout(callback,after,arg1,arg2,arg3){
+functionsetTimeout(callback,after,...args){
 validateFunction(callback,'callback');
-
-leti,args;
-switch(arguments.length){
-// fast cases
-case1:
-case2:
-break;
-case3:
-args=[arg1];
-break;
-case4:
-args=[arg1,arg2];
-break;
-default:
-args=[arg1,arg2,arg3];
-for(i=5;i<arguments.length;i++){
-// Extend array dynamically, makes .apply run much faster in v6.0.0
-ArrayPrototypePush(args,arguments[i]);
-}
-break;
-}
-
-consttimeout=newTimeout(callback,after,args,false,true);
+consttimeout=newTimeout(callback,after,args.length ? args : undefined,false,true);
 insert(timeout,timeout._idleTimeout);
-
 returntimeout;
 }
 
@@ -200,38 +174,13 @@ function clearTimeout(timer) {
  * every `repeat` milliseconds.
  * @param {Function} callback
  * @param {number} [repeat]
- * @param {any} [arg1]
- * @param {any} [arg2]
- * @param {any} [arg3]
+ * @param {...any} [args]
  * @returns {Timeout}
  */
-functionsetInterval(callback,repeat,arg1,arg2,arg3){
+functionsetInterval(callback,repeat,...args){
 validateFunction(callback,'callback');
-
-leti,args;
-switch(arguments.length){
-// fast cases
-case1:
-case2:
-break;
-case3:
-args=[arg1];
-break;
-case4:
-args=[arg1,arg2];
-break;
-default:
-args=[arg1,arg2,arg3];
-for(i=5;i<arguments.length;i++){
-// Extend array dynamically, makes .apply run much faster in v6.0.0
-ArrayPrototypePush(args,arguments[i]);
-}
-break;
-}
-
-consttimeout=newTimeout(callback,repeat,args,true,true);
+consttimeout=newTimeout(callback,repeat,args.length ? args : undefined,true,true);
 insert(timeout,timeout._idleTimeout);
-
 returntimeout;
 }
 
@@ -273,35 +222,12 @@ Timeout.prototype[SymbolToPrimitive] = function() {
  * Schedules the immediate execution of `callback`
  * after I/O events' callbacks.
  * @param {Function} callback
- * @param {any} [arg1]
- * @param {any} [arg2]
- * @param {any} [arg3]
+ * @param {...any} [args]
  * @returns {Immediate}
  */
-functionsetImmediate(callback,arg1,arg2,arg3){
+functionsetImmediate(callback,...args){
 validateFunction(callback,'callback');
-
-leti,args;
-switch(arguments.length){
-// fast cases
-case1:
-break;
-case2:
-args=[arg1];
-break;
-case3:
-args=[arg1,arg2];
-break;
-default:
-args=[arg1,arg2,arg3];
-for(i=4;i<arguments.length;i++){
-// Extend array dynamically, makes .apply run much faster in v6.0.0
-ArrayPrototypePush(args,arguments[i]);
-}
-break;
-}
-
-returnnewImmediate(callback,args);
+returnnewImmediate(callback,args.length ? args : undefined);
 }
 
 ObjectDefineProperty(setImmediate,customPromisify,{