dgram: remove unreachable connectState assign

pd4d10 · danielleadams · commit 906247933c16 · 2022-03-14T09:31:10.000-04:00
PR-URL: #38590 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/dgram.js b/lib/dgram.js
@@ -186,9 +186,6 @@ function replaceHandle(self, newHandle) {
 // Replace the existing handle by the handle we got from primary.
 oldHandle.close();
 state.handle = newHandle;
- // Check if the udp handle was connected and set the state accordingly
- if (isConnected(self))
- state.connectState = CONNECT_STATE_CONNECTED;
 }
 
 function bufferSize(self, size, buffer) {
@@ -292,10 +289,6 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) {
 if (err)
 throw errnoException(err, 'open');
 
- // Check if the udp handle was connected and set the state accordingly
- if (isConnected(this))
- state.connectState = CONNECT_STATE_CONNECTED;
-
 startListening(this);
 return this;
 }
@@ -553,16 +546,6 @@ function clearQueue() {
 queueEntry();
 }
 
-function isConnected(self) {
- try {
- self.remoteAddress();
- return true;
- } catch {
- return false;
- }
-}
-
-
 // valid combinations
 // For connectionless sockets
 // send(buffer, offset, length, port, address, callback)

-Original file line number
+Diff line change
 // Replace the existing handle by the handle we got from primary.
 oldHandle.close();
 state.handle=newHandle;
 -// Check if the udp handle was connected and set the state accordingly
 -if(isConnected(self))
 -state.connectState=CONNECT_STATE_CONNECTED;
+}
 functionbufferSize(self,size,buffer){
 if(err)
 throwerrnoException(err,'open');
 -// Check if the udp handle was connected and set the state accordingly
 -if(isConnected(this))
 -state.connectState=CONNECT_STATE_CONNECTED;
+-
 startListening(this);
 returnthis;
+}
 queueEntry();
+}
 -functionisConnected(self){
 -try{
 -self.remoteAddress();
 -returntrue;
 -}catch{
 -returnfalse;
 -}
 -}
+-
+-
 // valid combinations
 // For connectionless sockets
 // send(buffer, offset, length, port, address, callback)