benchmark: refactor deepequal-buffer

Trott · MylesBorins · commit 90d86586d2a3 · 2018-06-06T10:31:28.000+02:00
This is a minor refactor of benchmark/assert/deepequal-buffer.js to reduce exceptions that need to be made for lint compliance. PR-URL: #21030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/benchmark/assert/deepequal-buffer.js b/benchmark/assert/deepequal-buffer.js
@@ -14,6 +14,8 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ len, n, method }) {
+ if (!method)
+ method = 'deepEqual';
 const data = Buffer.allocUnsafe(len + 1);
 const actual = Buffer.alloc(len);
 const expected = Buffer.alloc(len);
@@ -22,8 +24,7 @@ function main({ len, n, method }) {
 data.copy(expected);
 data.copy(expectedWrong);
 
- // eslint-disable-next-line no-restricted-properties
- const fn = method !== '' ? assert[method] : assert.deepEqual;
+ const fn = assert[method];
 const value2 = method.includes('not') ? expectedWrong : expected;
 
 bench.start();

-Original file line number
+Diff line change
 });
 functionmain({ len, n, method }){
 +if(!method)
 +method='deepEqual';
 constdata=Buffer.allocUnsafe(len+1);
 constactual=Buffer.alloc(len);
 constexpected=Buffer.alloc(len);
 data.copy(expected);
 data.copy(expectedWrong);
 -// eslint-disable-next-line no-restricted-properties
 -constfn=method!=='' ? assert[method] : assert.deepEqual;
 +constfn=assert[method];
 constvalue2=method.includes('not') ? expectedWrong : expected;
 bench.start();