http: remove dead code from internal/http.js

Lxxyx · danielleadams · commit 9156f430b588 · 2021-01-12T07:10:03.000-05:00
PR-URL: #36630 Refs: #32329 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/http.js b/lib/internal/http.js
@@ -11,28 +11,20 @@ const {
 const { setUnrefTimeout } = require('internal/timers');
 const { PerformanceEntry, notify } = internalBinding('performance');
 
-let nowCache;
 let utcCache;
 
-function nowDate() {
- if (!nowCache) cache();
- return nowCache;
-}
-
 function utcDate() {
 if (!utcCache) cache();
 return utcCache;
 }
 
 function cache() {
 const d = new Date();
- nowCache = DatePrototypeValueOf(d);
- utcCache = DatePrototypeToUTCString(d);
- setUnrefTimeout(resetCache, 1000 - DatePrototypeGetMilliseconds(d));
+ utcCache = d.toUTCString();
+ setUnrefTimeout(resetCache, 1000 - d.getMilliseconds());
 }
 
 function resetCache() {
- nowCache = undefined;
 utcCache = undefined;
 }
 
@@ -55,7 +47,6 @@ function emitStatistics(statistics) {
 module.exports = {
 kOutHeaders: Symbol('kOutHeaders'),
 kNeedDrain: Symbol('kNeedDrain'),
- nowDate,
 utcDate,
 emitStatistics
 };

-Original file line number
+Diff line change
 const{ setUnrefTimeout }=require('internal/timers');
 const{ PerformanceEntry, notify }=internalBinding('performance');
 -letnowCache;
 letutcCache;
 -functionnowDate(){
 -if(!nowCache)cache();
 -returnnowCache;
 -}
+-
 functionutcDate(){
 if(!utcCache)cache();
 returnutcCache;
+}
 functioncache(){
 constd=newDate();
 -nowCache=DatePrototypeValueOf(d);
 -utcCache=DatePrototypeToUTCString(d);
 -setUnrefTimeout(resetCache,1000-DatePrototypeGetMilliseconds(d));
 +utcCache=d.toUTCString();
 +setUnrefTimeout(resetCache,1000-d.getMilliseconds());
+}
 functionresetCache(){
 -nowCache=undefined;
 utcCache=undefined;
+}
 module.exports={
 kOutHeaders: Symbol('kOutHeaders'),
 kNeedDrain: Symbol('kNeedDrain'),
 - nowDate,
  utcDate,
  emitStatistics
 };