process: remove support for undocumented symbol

PR-URL: #56552
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Author: aduh95

lib/internal/process/per_thread.js

@@ -420,15 +420,17 @@ function toggleTraceCategoryState(asyncHooksEnabled) {
 
 const{ arch, platform, version }=process;
 
+letrefSymbol;
 functionref(maybeRefable){
-constfn=maybeRefable?.[SymbolFor('nodejs.ref')]||maybeRefable?.[SymbolFor('node:ref')]||maybeRefable?.ref;
+if(maybeRefable==null)return;
+constfn=maybeRefable[refSymbol??=SymbolFor('nodejs.ref')]||maybeRefable.ref;
 if(typeoffn==='function')FunctionPrototypeCall(fn,maybeRefable);
 }
 
+letunrefSymbol;
 functionunref(maybeRefable){
-constfn=maybeRefable?.[SymbolFor('nodejs.unref')]||
-maybeRefable?.[SymbolFor('node:unref')]||
-maybeRefable?.unref;
+if(maybeRefable==null)return;
+constfn=maybeRefable[unrefSymbol??=SymbolFor('nodejs.unref')]||maybeRefable.unref;
 if(typeoffn==='function')FunctionPrototypeCall(fn,maybeRefable);
 }
 

test/parallel/test-process-ref-unref.js

@@ -33,37 +33,20 @@ class Foo2 {
 }
 }
 
-// TODO(aduh95): remove support for undocumented symbol
-classFoo3{
-refCalled=0;
-unrefCalled=0;
-[Symbol.for('node:ref')](){
-this.refCalled++;
-}
-[Symbol.for('node:unref')](){
-this.unrefCalled++;
-}
-}
-
 describe('process.ref/unref work as expected',()=>{
 it('refs...',()=>{
 // Objects that implement the new Symbol-based API
 // just work.
 constfoo1=newFoo();
 constfoo2=newFoo2();
-constfoo3=newFoo3();
 process.ref(foo1);
 process.unref(foo1);
 process.ref(foo2);
 process.unref(foo2);
-process.ref(foo3);
-process.unref(foo3);
 strictEqual(foo1.refCalled,1);
 strictEqual(foo1.unrefCalled,1);
 strictEqual(foo2.refCalled,1);
 strictEqual(foo2.unrefCalled,1);
-strictEqual(foo3.refCalled,1);
-strictEqual(foo3.unrefCalled,1);
 
 // Objects that implement the legacy API also just work.
 consti=setInterval(()=>{},1000);