tools: simplify lowercase-name-for-primitive rule

PR-URL: #17653
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Author: cjihrig

tools/eslint-rules/lowercase-name-for-primitive.js

@@ -9,41 +9,38 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
+constastSelector='NewExpression[callee.property.name="TypeError"]'+
+'[arguments.0.value="ERR_INVALID_ARG_TYPE"]';
+
 constprimitives=[
 'number','string','boolean','null','undefined'
 ];
 
 module.exports=function(context){
-return{
-NewExpression(node){
-if(
-node.callee.property&&
-node.callee.property.name==='TypeError'&&
-node.arguments[0].value==='ERR_INVALID_ARG_TYPE'
-){
-checkNamesArgument(node.arguments[2]);
-}
+functioncheckNamesArgument(node){
+constnames=node.arguments[2];
 
-functioncheckNamesArgument(names){
-switch(names.type){
-case'Literal':
-checkName(names.value);
-break;
-case'ArrayExpression':
-names.elements.forEach((name)=>{
-checkName(name.value);
-});
-break;
-}
-}
+switch(names.type){
+case'Literal':
+checkName(node,names.value);
+break;
+case'ArrayExpression':
+names.elements.forEach((name)=>{
+checkName(node,name.value);
+});
+break;
+}
+}
 
-functioncheckName(name){
-constlowercaseName=name.toLowerCase();
-if(primitives.includes(lowercaseName)&&!primitives.includes(name)){
-constmsg=`primitive should use lowercase: ${name}`;
-context.report(node,msg);
-}
-}
+functioncheckName(node,name){
+constlowercaseName=name.toLowerCase();
+if(primitives.includes(lowercaseName)&&!primitives.includes(name)){
+constmsg=`primitive should use lowercase: ${name}`;
+context.report(node,msg);
 }
+}
+
+return{
+[astSelector]: (node)=>checkNamesArgument(node)
 };
 };