module: fix $ pattern replacements

PR-URL: #40044
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

Author: guybedford

lib/internal/modules/esm/resolve.js

@@ -10,6 +10,7 @@ const {
  ObjectGetOwnPropertyNames,
  ObjectPrototypeHasOwnProperty,
  RegExp,
+ RegExpPrototypeSymbolReplace,
  RegExpPrototypeTest,
  SafeMap,
  SafeSet,
@@ -18,7 +19,6 @@ const {
  StringPrototypeIncludes,
  StringPrototypeIndexOf,
  StringPrototypeLastIndexOf,
- StringPrototypeReplace,
  StringPrototypeSlice,
  StringPrototypeSplit,
  StringPrototypeStartsWith,
@@ -470,7 +470,7 @@ function resolvePackageTargetString(
 }catch{}
 if(!isURL){
 constexportTarget=pattern ?
-StringPrototypeReplace(target,patternRegEx,subpath) :
+RegExpPrototypeSymbolReplace(patternRegEx,target,()=>subpath) :
 target+subpath;
 returnpackageResolve(exportTarget,packageJSONUrl,conditions);
 }
@@ -494,8 +494,8 @@ function resolvePackageTargetString(
 throwInvalidSubpath(match+subpath,packageJSONUrl,internal,base);
 
 if(pattern)
-returnnewURL(StringPrototypeReplace(resolved.href,patternRegEx,
-subpath));
+returnnewURL(RegExpPrototypeSymbolReplace(patternRegEx,resolved.href,
+()=>subpath));
 returnnewURL(subpath,resolved);
 }
 
@@ -939,7 +939,8 @@ function resolveAsCommonJS(specifier, parentURL) {
 // Normalize the path separator to give a valid suggestion
 // on Windows
 if(process.platform==='win32'){
-found=StringPrototypeReplace(found,newRegExp(`\\${sep}`,'g'),'/');
+found=RegExpPrototypeSymbolReplace(newRegExp(`\\${sep}`,'g'),
+found,'/');
 }
 returnfound;
 }catch{

test/es-module/test-esm-exports.mjs

@@ -156,6 +156,8 @@ import fromInside from '../fixtures/node_modules/pkgexports/lib/hole.js';
 ['pkgexports/no-ext',`pkgexports${sep}asdf`],
 // Pattern specificity
 ['pkgexports/dir2/trailer',`subpath${sep}dir2.js`],
+// Pattern double $$ escaping!
+['pkgexports/a/$$',`subpath${sep}$$.js`],
 ]);
 
 if(!isRequire){