fs: improve error performance of sync methods

PR-URL: #49593
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

Author: anonrig

benchmark/fs/bench-accessSync.js

@@ -0,0 +1,42 @@
+'use strict';
+
+constcommon=require('../common');
+constfs=require('fs');
+consttmpdir=require('../../test/common/tmpdir');
+tmpdir.refresh();
+
+consttmpfile=tmpdir.resolve(`.existing-file-${process.pid}`);
+fs.writeFileSync(tmpfile,'this-is-for-a-benchmark','utf8');
+
+constbench=common.createBenchmark(main,{
+type: ['existing','non-existing','non-flat-existing'],
+n: [1e5],
+});
+
+functionmain({ n, type }){
+letpath;
+
+switch(type){
+case'existing':
+path=__filename;
+break;
+case'non-flat-existing':
+path=tmpfile;
+break;
+case'non-existing':
+path=tmpdir.resolve(`.non-existing-file-${process.pid}`);
+break;
+default:
+newError('Invalid type');
+}
+
+bench.start();
+for(leti=0;i<n;i++){
+try{
+fs.accessSync(path);
+}catch{
+// do nothing
+}
+}
+bench.end(n);
+}

benchmark/fs/bench-copyFileSync.js

@@ -0,0 +1,37 @@
+'use strict';
+
+constcommon=require('../common');
+constfs=require('fs');
+consttmpdir=require('../../test/common/tmpdir');
+tmpdir.refresh();
+
+constbench=common.createBenchmark(main,{
+type: ['invalid','valid'],
+n: [1e4],
+});
+
+functionmain({ n, type }){
+tmpdir.refresh();
+constdest=tmpdir.resolve(`copy-file-bench-${process.pid}`);
+letpath;
+
+switch(type){
+case'invalid':
+path=tmpdir.resolve(`.existing-file-${process.pid}`);
+break;
+case'valid':
+path=__filename;
+break;
+default:
+thrownewError('Invalid type');
+}
+bench.start();
+for(leti=0;i<n;i++){
+try{
+fs.copyFileSync(path,dest);
+}catch{
+// do nothing
+}
+}
+bench.end(n);
+}

benchmark/fs/bench-existsSync.js

@@ -0,0 +1,38 @@
+'use strict';
+
+constcommon=require('../common');
+constfs=require('fs');
+consttmpdir=require('../../test/common/tmpdir');
+tmpdir.refresh();
+
+consttmpfile=tmpdir.resolve(`.existing-file-${process.pid}`);
+fs.writeFileSync(tmpfile,'this-is-for-a-benchmark','utf8');
+
+constbench=common.createBenchmark(main,{
+type: ['existing','non-existing','non-flat-existing'],
+n: [1e6],
+});
+
+functionmain({ n, type }){
+letpath;
+
+switch(type){
+case'existing':
+path=__filename;
+break;
+case'non-flat-existing':
+path=tmpfile;
+break;
+case'non-existing':
+path=tmpdir.resolve(`.non-existing-file-${process.pid}`);
+break;
+default:
+newError('Invalid type');
+}
+
+bench.start();
+for(leti=0;i<n;i++){
+fs.existsSync(path);
+}
+bench.end(n);
+}

benchmark/fs/bench-openSync.js

@@ -0,0 +1,37 @@
+'use strict';
+
+constcommon=require('../common');
+constfs=require('fs');
+consttmpdir=require('../../test/common/tmpdir');
+tmpdir.refresh();
+
+constbench=common.createBenchmark(main,{
+type: ['existing','non-existing'],
+n: [1e5],
+});
+
+functionmain({ n, type }){
+letpath;
+
+switch(type){
+case'existing':
+path=__filename;
+break;
+case'non-existing':
+path=tmpdir.resolve(`.non-existing-file-${process.pid}`);
+break;
+default:
+newError('Invalid type');
+}
+
+bench.start();
+for(leti=0;i<n;i++){
+try{
+constfd=fs.openSync(path,'r',0o666);
+fs.closeSync(fd);
+}catch{
+// do nothing
+}
+}
+bench.end(n);
+}

lib/fs.js

@@ -141,7 +141,7 @@ const {
  validateObject,
  validateString,
 }=require('internal/validators');
-const{ readFileSyncUtf8 }=require('internal/fs/read/utf8');
+constsyncFs=require('internal/fs/sync');
 
 lettruncateWarn=true;
 letfs;
@@ -243,12 +243,7 @@ function access(path, mode, callback) {
  * @returns {void}
  */
 functionaccessSync(path,mode){
-path=getValidatedPath(path);
-mode=getValidMode(mode,'access');
-
-constctx={ path };
-binding.access(pathModule.toNamespacedPath(path),mode,undefined,ctx);
-handleErrorFromBinding(ctx);
+syncFs.access(path,mode);
 }
 
 /**
@@ -290,23 +285,7 @@ ObjectDefineProperty(exists, kCustomPromisifiedSymbol, {
  * @returns {boolean}
  */
 functionexistsSync(path){
-try{
-path=getValidatedPath(path);
-}catch{
-returnfalse;
-}
-constctx={ path };
-constnPath=pathModule.toNamespacedPath(path);
-binding.access(nPath,F_OK,undefined,ctx);
-
-// In case of an invalid symlink, `binding.access()` on win32
-// will **not** return an error and is therefore not enough.
-// Double check with `binding.stat()`.
-if(isWindows&&ctx.errno===undefined){
-binding.stat(nPath,false,undefined,ctx);
-}
-
-returnctx.errno===undefined;
+returnsyncFs.exists(path);
 }
 
 functionreadFileAfterOpen(err,fd){
@@ -462,8 +441,7 @@ function readFileSync(path, options) {
 
 // TODO(@anonrig): Do not handle file descriptor ownership for now.
 if(!isUserFd&&(options.encoding==='utf8'||options.encoding==='utf-8')){
-path=getValidatedPath(path);
-returnreadFileSyncUtf8(pathModule.toNamespacedPath(path),stringToFlags(options.flag));
+returnsyncFs.readFileUtf8(path,options.flag);
 }
 
 constfd=isUserFd ? path : fs.openSync(path,options.flag,0o666);
@@ -540,11 +518,7 @@ function close(fd, callback = defaultCloseCallback) {
  * @returns {void}
  */
 functioncloseSync(fd){
-fd=getValidatedFd(fd);
-
-constctx={};
-binding.close(fd,undefined,ctx);
-handleErrorFromBinding(ctx);
+returnsyncFs.close(fd);
 }
 
 /**
@@ -590,16 +564,7 @@ function open(path, flags, mode, callback) {
  * @returns {number}
  */
 functionopenSync(path,flags,mode){
-path=getValidatedPath(path);
-constflagsNumber=stringToFlags(flags);
-mode=parseFileMode(mode,'mode',0o666);
-
-constctx={ path };
-constresult=binding.open(pathModule.toNamespacedPath(path),
-flagsNumber,mode,
-undefined,ctx);
-handleErrorFromBinding(ctx);
-returnresult;
+returnsyncFs.open(path,flags,mode);
 }
 
 /**
@@ -1702,25 +1667,12 @@ function lstatSync(path, options = { bigint: false, throwIfNoEntry: true }) {
  * }} [options]
  * @returns {Stats}
  */
-functionstatSync(path,options={bigint: false,throwIfNoEntry: true}){
-path=getValidatedPath(path);
-constctx={ path };
-conststats=binding.stat(pathModule.toNamespacedPath(path),
-options.bigint,undefined,ctx);
-if(options.throwIfNoEntry===false&&hasNoEntryError(ctx)){
-returnundefined;
-}
-handleErrorFromBinding(ctx);
-returngetStatsFromBinding(stats);
+functionstatSync(path,options){
+returnsyncFs.stat(path,options);
 }
 
-functionstatfsSync(path,options={bigint: false}){
-path=getValidatedPath(path);
-constctx={ path };
-conststats=binding.statfs(pathModule.toNamespacedPath(path),
-options.bigint,undefined,ctx);
-handleErrorFromBinding(ctx);
-returngetStatFsFromBinding(stats);
+functionstatfsSync(path,options){
+returnsyncFs.statfs(path,options);
 }
 
 /**
@@ -2999,16 +2951,7 @@ function copyFile(src, dest, mode, callback) {
  * @returns {void}
  */
 functioncopyFileSync(src,dest,mode){
-src=getValidatedPath(src,'src');
-dest=getValidatedPath(dest,'dest');
-
-constctx={path: src, dest };// non-prefixed
-
-src=pathModule._makeLong(src);
-dest=pathModule._makeLong(dest);
-mode=getValidMode(mode,'copyFile');
-binding.copyFile(src,dest,mode,undefined,ctx);
-handleErrorFromBinding(ctx);
+syncFs.copyFile(src,dest,mode);
 }
 
 /**