test: add typeerror test for EC crypto keygen

teorossi82 · codebytere · commit 94553b2ea573 · 2019-01-28T21:54:52.000-08:00
PR-URL: #24400 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-crypto-keygen.js b/test/parallel/test-crypto-keygen.js
@@ -625,6 +625,22 @@ function convertDERToPEM(label, der) {
 message: 'Invalid ECDH curve name'
 });
 
+ // Test error type when curve is not a string
+ for (const namedCurve of [true, {}, [], 123]) {
+ common.expectsError(() => {
+ generateKeyPairSync('ec', {
+ namedCurve,
+ publicKeyEncoding: { type: 'spki', format: 'pem' },
+ privateKeyEncoding: { type: 'sec1', format: 'pem' }
+ });
+ }, {
+ type: TypeError,
+ code: 'ERR_INVALID_OPT_VALUE',
+ message: `The value "${namedCurve}" is invalid for option ` +
+ '"namedCurve"'
+ });
+ }
+
 // It should recognize both NIST and standard curve names.
 generateKeyPair('ec', {
 namedCurve: 'P-192',

-Original file line number
+Diff line change
 message: 'Invalid ECDH curve name'
 });
 +// Test error type when curve is not a string
 +for(constnamedCurveof[true,{},[],123]){
 +common.expectsError(()=>{
 +generateKeyPairSync('ec',{
 + namedCurve,
 +publicKeyEncoding: {type: 'spki',format: 'pem'},
 +privateKeyEncoding: {type: 'sec1',format: 'pem'}
 +});
 +},{
 +type: TypeError,
 +code: 'ERR_INVALID_OPT_VALUE',
 +message: `The value "${namedCurve}" is invalid for option `+
 +'"namedCurve"'
 +});
 +}
++
 // It should recognize both NIST and standard curve names.
 generateKeyPair('ec',{
 namedCurve: 'P-192',