tools: enable additional lint rules

Enable additional likely-uncontroversial lint rules:
* `comma-dangle` set to prohibit dangling commas on objects and arrays
that are defined on a single line. Multi-line definitions can use or
omit a trailing comma.
* `no-unused-labels` Prohibits defining a label that is not used.
* `no-path-concat` Prohibits string-concatenation using i`__dirname` and
`__filename`. Use `path.join()`, `path.resolve()`, or template strings
instead.
* `no-new-symbol` disallow use of `new` operator with `Symbol` object.
Violating this rule would result in a `TypeError` at runtime.`
PR-URL: #5357
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

Author: Trott

.eslintrc

@@ -5,6 +5,7 @@ env:
 rules:
  # Possible Errors
  # https://github.com/eslint/eslint/tree/master/docs/rules#possible-errors
+ comma-dangle: [2, "only-multiline"]
  no-control-regex: 2
  no-debugger: 2
  no-dupe-args: 2
@@ -30,6 +31,7 @@ rules:
  no-fallthrough: 2
  no-octal: 2
  no-redeclare: 2
+ no-unused-labels: 2
 
  # Variables
  # http://eslint.org/docs/rules/#variables
@@ -41,6 +43,7 @@ rules:
  # http://eslint.org/docs/rules/#nodejs-and-commonjs
  no-mixed-requires: 2
  no-new-require: 2
+ no-path-concat: 2
  no-restricted-modules: [2, "sys", "_linklist"]
 
  # Stylistic Issues
@@ -71,6 +74,7 @@ rules:
  no-confusing-arrow: 2
  no-const-assign: 2
  no-dupe-class-members: 2
+ no-new-symbol: 2
  no-this-before-super: 2
  prefer-const: 2
 

test/parallel/test-fs-access.js

@@ -3,7 +3,7 @@ var common = require('../common');
 varassert=require('assert');
 varfs=require('fs');
 varpath=require('path');
-vardoesNotExist=__filename+'__this_should_not_exist';
+vardoesNotExist=path.join(common.tmpDir,'__this_should_not_exist');
 varreadOnlyFile=path.join(common.tmpDir,'read_only_file');
 varreadWriteFile=path.join(common.tmpDir,'read_write_file');
 

test/parallel/test-fs-stat.js

@@ -68,7 +68,7 @@ fs.open('.', 'r', undefined, function(err, fd) {
 fs.close(fd);
 });
 
-console.log('stating: '+__filename);
+console.log(`stating: ${__filename}`);
 fs.stat(__filename,function(err,s){
 if(err){
 got_error=true;

test/parallel/test-stdio-closed.js

@@ -18,7 +18,7 @@ if (process.argv[2] === 'child') {
 }
 
 // Run the script in a shell but close stdout and stderr.
-varcmd='"'+process.execPath+'" "'+__filename+'" child 1>&- 2>&-';
+varcmd=`"${process.execPath}" "${__filename}" child 1>&- 2>&-`;
 varproc=spawn('/bin/sh',['-c',cmd],{stdio: 'inherit'});
 
 proc.on('exit',common.mustCall(function(exitCode){