test: improve code in test-vm-symbols

edsadr · MylesBorins · commit 9840f505f0d3 · 2017-01-31T20:04:29.000-05:00
* use const instead of var * use assert.strictEqual instead of assert.equal PR-URL: #10429 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/test-vm-symbols.js b/test/parallel/test-vm-symbols.js
@@ -1,11 +1,11 @@
 'use strict';
 
 require('../common');
-var assert = require('assert');
+const assert = require('assert');
 
-var vm = require('vm');
+const vm = require('vm');
 
-var symbol = Symbol();
+const symbol = Symbol();
 
 function Document() {
 this[symbol] = 'foo';
@@ -15,11 +15,11 @@ Document.prototype.getSymbolValue = function() {
 return this[symbol];
 };
 
-var context = new Document();
+const context = new Document();
 vm.createContext(context);
 
-assert.equal(context.getSymbolValue(), 'foo',
+assert.strictEqual(context.getSymbolValue(), 'foo',
 'should return symbol-keyed value from the outside');
 
-assert.equal(vm.runInContext('this.getSymbolValue()', context), 'foo',
+assert.strictEqual(vm.runInContext('this.getSymbolValue()', context), 'foo',
 'should return symbol-keyed value from the inside');

-Original file line number
+Diff line change
@@ @@ -1,11 +1,11 @@ @@
 'use strict';
 require('../common');
 -varassert=require('assert');
 +constassert=require('assert');
 -varvm=require('vm');
 +constvm=require('vm');
 -varsymbol=Symbol();
 +constsymbol=Symbol();
 functionDocument(){
 this[symbol]='foo';
 returnthis[symbol];
 };
 -varcontext=newDocument();
 +constcontext=newDocument();
 vm.createContext(context);
 -assert.equal(context.getSymbolValue(),'foo',
 +assert.strictEqual(context.getSymbolValue(),'foo',
 'should return symbol-keyed value from the outside');
 -assert.equal(vm.runInContext('this.getSymbolValue()',context),'foo',
 +assert.strictEqual(vm.runInContext('this.getSymbolValue()',context),'foo',
 'should return symbol-keyed value from the inside');