Skip to content

Commit 9b0fc59

Browse files
TrottMylesBorins
authored andcommitted
benchmark: refactor deepequal-map
This is a minor refactor of benchmark/assert/deepequal-map.js to reduce exceptions that need to be made for lint compliance. PR-URL: #21030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 90d8658 commit 9b0fc59

1 file changed

Lines changed: 16 additions & 17 deletions

File tree

‎benchmark/assert/deepequal-map.js‎

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
'use strict';
22

3-
/* eslint-disable no-restricted-properties */
4-
53
constcommon=require('../common.js');
6-
constassert=require('assert');
4+
const{ deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual }=
5+
require('assert');
76

87
constbench=common.createBenchmark(main,{
98
n: [5e2],
@@ -47,74 +46,74 @@ function main({ n, len, method }) {
4746
// Empty string falls through to next line as default, mostly for tests.
4847
case'deepEqual_primitiveOnly':
4948
values=array.map((_,i)=>[`str_${i}`,123]);
50-
benchmark(assert.deepEqual,n,values);
49+
benchmark(deepEqual,n,values);
5150
break;
5251
case'deepStrictEqual_primitiveOnly':
5352
values=array.map((_,i)=>[`str_${i}`,123]);
54-
benchmark(assert.deepStrictEqual,n,values);
53+
benchmark(deepStrictEqual,n,values);
5554
break;
5655
case'deepEqual_objectOnly':
5756
values=array.map((_,i)=>[[`str_${i}`,1],123]);
58-
benchmark(assert.deepEqual,n,values);
57+
benchmark(deepEqual,n,values);
5958
break;
6059
case'deepStrictEqual_objectOnly':
6160
values=array.map((_,i)=>[[`str_${i}`,1],123]);
62-
benchmark(assert.deepStrictEqual,n,values);
61+
benchmark(deepStrictEqual,n,values);
6362
break;
6463
case'deepEqual_mixed':
6564
values=array.map((_,i)=>[i%2 ? [`str_${i}`,1] : `str_${i}`,123]);
66-
benchmark(assert.deepEqual,n,values);
65+
benchmark(deepEqual,n,values);
6766
break;
6867
case'deepStrictEqual_mixed':
6968
values=array.map((_,i)=>[i%2 ? [`str_${i}`,1] : `str_${i}`,123]);
70-
benchmark(assert.deepStrictEqual,n,values);
69+
benchmark(deepStrictEqual,n,values);
7170
break;
7271
case'deepEqual_looseMatches':
7372
values=array.map((_,i)=>[i,i]);
7473
values2=values.slice().map((v)=>[String(v[0]),String(v[1])]);
75-
benchmark(assert.deepEqual,n,values,values2);
74+
benchmark(deepEqual,n,values,values2);
7675
break;
7776
case'notDeepEqual_primitiveOnly':
7877
values=array.map((_,i)=>[`str_${i}`,123]);
7978
values2=values.slice(0);
8079
values2[Math.floor(len/2)]=['w00t',123];
81-
benchmark(assert.notDeepEqual,n,values,values2);
80+
benchmark(notDeepEqual,n,values,values2);
8281
break;
8382
case'notDeepStrictEqual_primitiveOnly':
8483
values=array.map((_,i)=>[`str_${i}`,123]);
8584
values2=values.slice(0);
8685
values2[Math.floor(len/2)]=['w00t',123];
87-
benchmark(assert.notDeepStrictEqual,n,values,values2);
86+
benchmark(notDeepStrictEqual,n,values,values2);
8887
break;
8988
case'notDeepEqual_objectOnly':
9089
values=array.map((_,i)=>[[`str_${i}`,1],123]);
9190
values2=values.slice(0);
9291
values2[Math.floor(len/2)]=[['w00t'],123];
93-
benchmark(assert.notDeepEqual,n,values,values2);
92+
benchmark(notDeepEqual,n,values,values2);
9493
break;
9594
case'notDeepStrictEqual_objectOnly':
9695
values=array.map((_,i)=>[[`str_${i}`,1],123]);
9796
values2=values.slice(0);
9897
values2[Math.floor(len/2)]=[['w00t'],123];
99-
benchmark(assert.notDeepStrictEqual,n,values,values2);
98+
benchmark(notDeepStrictEqual,n,values,values2);
10099
break;
101100
case'notDeepEqual_mixed':
102101
values=array.map((_,i)=>[i%2 ? [`str_${i}`,1] : `str_${i}`,123]);
103102
values2=values.slice(0);
104103
values2[0]=['w00t',123];
105-
benchmark(assert.notDeepEqual,n,values,values2);
104+
benchmark(notDeepEqual,n,values,values2);
106105
break;
107106
case'notDeepStrictEqual_mixed':
108107
values=array.map((_,i)=>[i%2 ? [`str_${i}`,1] : `str_${i}`,123]);
109108
values2=values.slice(0);
110109
values2[0]=['w00t',123];
111-
benchmark(assert.notDeepStrictEqual,n,values,values2);
110+
benchmark(notDeepStrictEqual,n,values,values2);
112111
break;
113112
case'notDeepEqual_looseMatches':
114113
values=array.map((_,i)=>[i,i]);
115114
values2=values.slice().map((v)=>[String(v[0]),String(v[1])]);
116115
values2[len-1]=[String(len+1),String(len+1)];
117-
benchmark(assert.notDeepEqual,n,values,values2);
116+
benchmark(notDeepEqual,n,values,values2);
118117
break;
119118
default:
120119
thrownewError(`Unsupported method ${method}`);

0 commit comments

Comments
 (0)