test: make test-os-eol engine agnostic

Trott · evanlucas · commit 9bf887475ea8 · 2017-11-13T07:59:52.000-06:00
Do not check the error message if it is generated by the JavaScript engine (V8, ChakraCore, etc.). Do confirm that it is a `TypeError`. PR-URL: #16272 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
diff --git a/test/parallel/test-os-eol.js b/test/parallel/test-os-eol.js
@@ -8,12 +8,9 @@ const eol = common.isWindows ? '\r\n' : '\n';
 
 assert.strictEqual(os.EOL, eol);
 
-common.expectsError(function() {
- os.EOL = 123;
-}, {
- type: TypeError,
- message: /^Cannot assign to read only property 'EOL' of object '#<Object>'$/
-});
+// Test that the `Error` is a `TypeError` but do not check the message as it
+// varies between different JavaScript engines.
+assert.throws(function() { os.EOL = 123; }, TypeError);
 
 const foo = 'foo';
 Object.defineProperties(os, {

-Original file line number
+Diff line change
 assert.strictEqual(os.EOL,eol);
 -common.expectsError(function(){
 -os.EOL=123;
 -},{
 -type: TypeError,
 -message: /^Cannotassigntoreadonlyproperty'EOL'ofobject'#<Object>'$/
 -});
 +// Test that the `Error` is a `TypeError` but do not check the message as it
 +// varies between different JavaScript engines.
 +assert.throws(function(){os.EOL=123;},TypeError);
 constfoo='foo';
 Object.defineProperties(os,{