test: improve readline/emitKeypressEvents.js coverage

Y1D7NG · bengl · commit 9cc5ce6a24be · 2022-05-30T12:33:54.000-04:00
PR-URL: #42908 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/test/parallel/test-readline-emit-keypress-events.js b/test/parallel/test-readline-emit-keypress-events.js
@@ -7,22 +7,66 @@ require('../common');
 const assert = require('assert');
 const readline = require('readline');
 const PassThrough = require('stream').PassThrough;
-const stream = new PassThrough();
-const sequence = [];
-const keys = [];
 
-readline.emitKeypressEvents(stream);
-
-stream.on('keypress', (s, k) => {
- sequence.push(s);
- keys.push(k);
-});
-
-stream.write('foo');
-
-assert.deepStrictEqual(sequence, ['f', 'o', 'o']);
-assert.deepStrictEqual(keys, [
+const expectedSequence = ['f', 'o', 'o'];
+const expectedKeys = [
 { sequence: 'f', name: 'f', ctrl: false, meta: false, shift: false },
 { sequence: 'o', name: 'o', ctrl: false, meta: false, shift: false },
 { sequence: 'o', name: 'o', ctrl: false, meta: false, shift: false },
-]);
+];
+
+{
+ const stream = new PassThrough();
+ const sequence = [];
+ const keys = [];
+
+ readline.emitKeypressEvents(stream);
+ stream.on('keypress', (s, k) => {
+ sequence.push(s);
+ keys.push(k);
+ });
+ stream.write('foo');
+
+ assert.deepStrictEqual(sequence, expectedSequence);
+ assert.deepStrictEqual(keys, expectedKeys);
+}
+
+{
+ const stream = new PassThrough();
+ const sequence = [];
+ const keys = [];
+
+ stream.on('keypress', (s, k) => {
+ sequence.push(s);
+ keys.push(k);
+ });
+ readline.emitKeypressEvents(stream);
+ stream.write('foo');
+
+ assert.deepStrictEqual(sequence, expectedSequence);
+ assert.deepStrictEqual(keys, expectedKeys);
+}
+
+{
+ const stream = new PassThrough();
+ const sequence = [];
+ const keys = [];
+ const keypressListener = (s, k) => {
+ sequence.push(s);
+ keys.push(k);
+ };
+
+ stream.on('keypress', keypressListener);
+ readline.emitKeypressEvents(stream);
+ stream.removeListener('keypress', keypressListener);
+ stream.write('foo');
+
+ assert.deepStrictEqual(sequence, []);
+ assert.deepStrictEqual(keys, []);
+
+ stream.on('keypress', keypressListener);
+ stream.write('foo');
+
+ assert.deepStrictEqual(sequence, expectedSequence);
+ assert.deepStrictEqual(keys, expectedKeys);
+}

-Original file line number
+Diff line change
 constassert=require('assert');
 constreadline=require('readline');
 constPassThrough=require('stream').PassThrough;
 -conststream=newPassThrough();
 -constsequence=[];
 -constkeys=[];
 -readline.emitKeypressEvents(stream);
+-
 -stream.on('keypress',(s,k)=>{
 -sequence.push(s);
 -keys.push(k);
 -});
+-
 -stream.write('foo');
+-
 -assert.deepStrictEqual(sequence,['f','o','o']);
 -assert.deepStrictEqual(keys,[
 +constexpectedSequence=['f','o','o'];
 +constexpectedKeys=[
 {sequence: 'f',name: 'f',ctrl: false,meta: false,shift: false},
 {sequence: 'o',name: 'o',ctrl: false,meta: false,shift: false},
 {sequence: 'o',name: 'o',ctrl: false,meta: false,shift: false},
 -]);
 +];
++
 +{
 +conststream=newPassThrough();
 +constsequence=[];
 +constkeys=[];
++
 +readline.emitKeypressEvents(stream);
 +stream.on('keypress',(s,k)=>{
 +sequence.push(s);
 +keys.push(k);
 +});
 +stream.write('foo');
++
 +assert.deepStrictEqual(sequence,expectedSequence);
 +assert.deepStrictEqual(keys,expectedKeys);
 +}
++
 +{
 +conststream=newPassThrough();
 +constsequence=[];
 +constkeys=[];
++
 +stream.on('keypress',(s,k)=>{
 +sequence.push(s);
 +keys.push(k);
 +});
 +readline.emitKeypressEvents(stream);
 +stream.write('foo');
++
 +assert.deepStrictEqual(sequence,expectedSequence);
 +assert.deepStrictEqual(keys,expectedKeys);
 +}
++
 +{
 +conststream=newPassThrough();
 +constsequence=[];
 +constkeys=[];
 +constkeypressListener=(s,k)=>{
 +sequence.push(s);
 +keys.push(k);
 +};
++
 +stream.on('keypress',keypressListener);
 +readline.emitKeypressEvents(stream);
 +stream.removeListener('keypress',keypressListener);
 +stream.write('foo');
++
 +assert.deepStrictEqual(sequence,[]);
 +assert.deepStrictEqual(keys,[]);
++
 +stream.on('keypress',keypressListener);
 +stream.write('foo');
++
 +assert.deepStrictEqual(sequence,expectedSequence);
 +assert.deepStrictEqual(keys,expectedKeys);
 +}