stream: readable use bitmap accessors

PR-URL: #50350
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

Author: ronag

lib/internal/streams/readable.js

@@ -431,7 +431,7 @@ function readableAddChunkUnshiftObjectMode(stream, state, chunk) {
 functionreadableAddChunkUnshiftValue(stream,state,chunk){
 if((state[kState]&kEndEmitted)!==0)
 errorOrDestroy(stream,newERR_STREAM_UNSHIFT_AFTER_END_EVENT());
-elseif(state.destroyed||state.errored)
+elseif((state[kState]&(kDestroyed|kErrored))!==0)
 returnfalse;
 else
 addChunk(stream,state,chunk,true);
@@ -608,7 +608,7 @@ function computeNewHighWaterMark(n) {
 // This function is designed to be inlinable, so please take care when making
 // changes to the function body.
 functionhowMuchToRead(n,state){
-if(n<=0||(state.length===0&&state.ended))
+if(n<=0||(state.length===0&&(state[kState]&kEnded)!==0))
 return0;
 if((state[kState]&kObjectMode)!==0)
 return1;
@@ -652,7 +652,7 @@ Readable.prototype.read = function(n) {
 state.length>=state.highWaterMark :
 state.length>0)||
 (state[kState]&kEnded)!==0)){
-debug('read: emitReadable',state.length,(state[kState]&kEnded)!==0);
+debug('read: emitReadable');
 if(state.length===0&&(state[kState]&kEnded)!==0)
 endReadable(this);
 else
@@ -810,7 +810,7 @@ function emitReadable(stream) {
 functionemitReadable_(stream){
 conststate=stream._readableState;
 debug('emitReadable_');
-if((state[kState]&(kDestroyed|kErrored))===0&&(state.length||state.ended)){
+if((state[kState]&(kDestroyed|kErrored))===0&&(state.length||(state[kState]&kEnded)!==0)){
 stream.emit('readable');
 state[kState]&=~kEmittedReadable;
 }
@@ -891,7 +891,7 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
 conststate=this._readableState;
 
 if(state.pipes.length===1){
-if(!state.multiAwaitDrain){
+if((state[kState]&kMultiAwaitDrain)===0){
 state[kState]|=kMultiAwaitDrain;
 state.awaitDrainWriters=newSafeSet(
 state.awaitDrainWriters ? [state.awaitDrainWriters] : [],
@@ -907,7 +907,7 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
 dest!==process.stderr;
 
 constendFn=doEnd ? onend : unpipe;
-if(state.endEmitted)
+if((state[kState]&kEndEmitted)!==0)
 process.nextTick(endFn);
 else
 src.once('end',endFn);
@@ -966,7 +966,7 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
 if(state.pipes.length===1&&state.pipes[0]===dest){
 debug('false write response, pause',0);
 state.awaitDrainWriters=dest;
-state.multiAwaitDrain=false;
+state[kState]&=~kMultiAwaitDrain;
 }elseif(state.pipes.length>1&&state.pipes.includes(dest)){
 debug('false write response, pause',state.awaitDrainWriters.size);
 state.awaitDrainWriters.add(dest);
@@ -1038,7 +1038,7 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
 
 if(dest.writableNeedDrain===true){
 pause();
-}elseif(!state.flowing){
+}elseif((state[kState]&kFlowing)===0){
 debug('pipe resume');
 src.resume();
 }
@@ -1056,7 +1056,7 @@ function pipeOnDrain(src, dest) {
 if(state.awaitDrainWriters===dest){
 debug('pipeOnDrain',1);
 state.awaitDrainWriters=null;
-}elseif(state.multiAwaitDrain){
+}elseif((state[kState]&kMultiAwaitDrain)!==0){
 debug('pipeOnDrain',state.awaitDrainWriters.size);
 state.awaitDrainWriters.delete(dest);
 }
@@ -1111,20 +1111,20 @@ Readable.prototype.on = function(ev, fn) {
 if(ev==='data'){
 // Update readableListening so that resume() may be a no-op
 // a few lines down. This is needed to support once('readable').
-state.readableListening=this.listenerCount('readable')>0;
+state[kState]|=this.listenerCount('readable')>0 ? kReadableListening :0;
 
 // Try start flowing on next tick if stream isn't explicitly paused.
-if(state.flowing!==false)
+if((state[kState]&(kHasFlowing|kFlowing))!==kHasFlowing){
 this.resume();
+}
 }elseif(ev==='readable'){
-if(!state.endEmitted&&!state.readableListening){
-state.readableListening=state.needReadable=true;
-state.flowing=false;
-state.emittedReadable=false;
-debug('on readable',state.length,state.reading);
+if((state[kState]&(kEndEmitted|kReadableListening))===0){
+state[kState]|=kReadableListening|kNeedReadable|kHasFlowing;
+state[kState]&=~(kFlowing|kEmittedReadable);
+debug('on readable');
 if(state.length){
 emitReadable(this);
-}elseif(!state.reading){
+}elseif((state[kState]&kReading)===0){
 process.nextTick(nReadingNextTick,this);
 }
 }
@@ -1171,7 +1171,12 @@ Readable.prototype.removeAllListeners = function(ev) {
 
 functionupdateReadableListening(self){
 conststate=self._readableState;
-state.readableListening=self.listenerCount('readable')>0;
+
+if(self.listenerCount('readable')>0){
+state[kState]|=kReadableListening;
+}else{
+state[kState]&=~kReadableListening;
+}
 
 if((state[kState]&(kHasPaused|kPaused|kResumeScheduled))===(kHasPaused|kResumeScheduled)){
 // Flowing needs to be set to true now, otherwise
@@ -1201,7 +1206,7 @@ Readable.prototype.resume = function() {
 // for readable, but we still have to call
 // resume().
 state[kState]|=kHasFlowing;
-if(!state.readableListening){
+if((state[kState]&kReadableListening)===0){
 state[kState]|=kFlowing;
 }else{
 state[kState]&=~kFlowing;
@@ -1214,8 +1219,8 @@ Readable.prototype.resume = function() {
 };
 
 functionresume(stream,state){
-if(!state.resumeScheduled){
-state.resumeScheduled=true;
+if((state[kState]&kResumeScheduled)===0){
+state[kState]|=kResumeScheduled;
 process.nextTick(resume_,stream,state);
 }
 }
@@ -1236,7 +1241,7 @@ function resume_(stream, state) {
 Readable.prototype.pause=function(){
 conststate=this._readableState;
 debug('call pause');
-if(state.flowing!==false){
+if((state[kState]&(kHasFlowing|kFlowing))!==kHasFlowing){
 debug('pause');
 state[kState]|=kHasFlowing;
 state[kState]&=~kFlowing;
@@ -1651,20 +1656,19 @@ function fromList(n, state) {
 functionendReadable(stream){
 conststate=stream._readableState;
 
-debug('endReadable',(state[kState]&kEndEmitted)!==0);
+debug('endReadable');
 if((state[kState]&kEndEmitted)===0){
 state[kState]|=kEnded;
 process.nextTick(endReadableNT,state,stream);
 }
 }
 
 functionendReadableNT(state,stream){
-debug('endReadableNT',state.endEmitted,state.length);
+debug('endReadableNT');
 
 // Check that we didn't get one last unshift.
-if(!state.errored&&!state.closeEmitted&&
-!state.endEmitted&&state.length===0){
-state.endEmitted=true;
+if((state[kState]&(kErrored|kCloseEmitted|kEndEmitted))===0&&state.length===0){
+state[kState]|=kEndEmitted;
 stream.emit('end');
 
 if(stream.writable&&stream.allowHalfOpen===false){